[ET-VK] Removing tile input storage variable in conv_pw op and fetching the data in main loop. Also unrolling the main loop for performance improvement. #6765
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng the data in main loop. Also unrolling the main loop for performance improvement. This diff removes the tile input storage array in_tex in the conv_pw op and fetches the data in the main loop for performance improvement. The main loop has also been unrolled for performance improvement. Differential Revision: [D64767314](https://our.internmc.facebook.com/intern/diff/D64767314/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6765
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 814324c with merge base 793f17e ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
This was referenced Nov 11, 2024
|
This pull request was exported from Phabricator. Differential Revision: D64767314 |
SS-JIA
approved these changes
Nov 11, 2024
facebook-github-bot
merged commit 1cb0b72
into
gh/trivedivivek/11/base
41 checks passed
facebook-github-bot
temporarily deployed
to
cherry-pick-bot
GitHub Actions
Inactive
SS-JIA
pushed a commit
that referenced
this pull request
Nov 12, 2024
…ng the data in main loop. Also unrolling the main loop for performance improvement. This diff removes the tile input storage array in_tex in the conv_pw op and fetches the data in the main loop for performance improvement. The main loop has also been unrolled for performance improvement. Differential Revision: [D64767314](https://our.internmc.facebook.com/intern/diff/D64767314/) ghstack-source-id: 252923517 Pull Request resolved: #6765
SS-JIA
pushed a commit
that referenced
this pull request
Nov 12, 2024
…ng the data in main loop. Also unrolling the main loop for performance improvement. (#6775) This diff removes the tile input storage array in_tex in the conv_pw op and fetches the data in the main loop for performance improvement. The main loop has also been unrolled for performance improvement. Differential Revision: [D64767314](https://our.internmc.facebook.com/intern/diff/D64767314/) ghstack-source-id: 252923517 Pull Request resolved: #6765 Co-authored-by: Vivek Trivedi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
This diff removes the tile input storage array in_tex in the conv_pw op and fetches the data in the main loop for performance improvement.
The main loop has also been unrolled for performance improvement.
Differential Revision: D64767314