Skip to content

Conversation

@cccclai
Copy link
Contributor

@cccclai cccclai commented Nov 12, 2024

Differential Revision: D64189995

@pytorch-bot
Copy link

pytorch-bot bot commented Nov 12, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6800

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures

As of commit 08cb3f7 with merge base 4b7a60f (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 12, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D64189995

Summary: Pull Request resolved: pytorch#6800

Differential Revision: D64189995
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D64189995

@cccclai
Copy link
Contributor Author

cccclai commented Nov 19, 2024

@chiwwang here is one thing we can do to optimize the memory. For 1b model, the embedding is shared with the last linear weight, so ideally, we can save more memory if it's enabled.

@chiwwang
Copy link
Contributor

@shewu-quic for awareness. This might also help us reduce memory usage.

@github-actions
Copy link

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

@github-actions github-actions bot added the stale PRs inactive for over 60 days label Aug 29, 2025
@github-actions
Copy link

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported stale PRs inactive for over 60 days

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants