Refactor tosa_utils #6810
Merged
Refactor tosa_utils #6810
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move process_output, process_inputs and process_call_function to a separate file named process_node. This removes the circular dependency between tosa_utils.py and node_visitor.py. Signed-off-by: Oscar Andersson <[email protected]> Change-Id: I5bfe42ad6cd36c579390af6d7fa14c8fb7341842
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6810
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit d67f6d6 with merge base 97e0417 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
oscarandersson8218
added
partner: arm
freddan80
approved these changes
Nov 13, 2024
lucylq
added a commit
to lucylq/executorch-1
that referenced
this pull request
Nov 13, 2024
Summary: D65876547, pytorch#6810 broke internal Jarvis test. This diff adds the missing buck dependencies. Differential Revision: D65901748
lucylq
added a commit
to lucylq/executorch-1
that referenced
this pull request
Nov 13, 2024
Summary: Pull Request resolved: pytorch#6833 Resolves internal Jarvis test failures from: D65876547, pytorch#6810 This diff adds the missing buck dependencies. Differential Revision: D65901748
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Move process_output, process_inputs and process_call_function to a separate file named process_node. This removes a circular dependency between tosa_utils.py and node_visitor.py.