Skip to content

Conversation

@cbilgin
Copy link

@cbilgin cbilgin commented Nov 15, 2024

Summary

Adds back the to_edge and partition apis to the existing tests. See for more details T206498038.

Test plan

python -m unittest backends/xnnpack/test/ops/add.py

@pytorch-bot
Copy link

pytorch-bot bot commented Nov 15, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6907

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ No Failures

As of commit fda0b1f with merge base 7b76f0f (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 15, 2024
@mcr229
Copy link
Contributor

mcr229 commented Nov 15, 2024

Error (FLAKE8) F821
    undefined name 'tesster'
    See https://www.flake8rules.com/rules/F821.html.
        251  |            tester.check_count(
        252  |                {"torch.ops.aten.add.Tensor": 1, "torch.ops.aten.relu.default": 1}
        253  |            )
    >>> 254  |            tesster.check(["torch.ops.quantized_decomposed"])
        255  |            if legacy:
        256  |                tester.to_edge()
        257  |                tester.partition()
  Warning (UFMT) format
    Run `lintrunner -a` to apply this patch.
    You can run `lintrunner -a` to apply this patch.
    211  211 |                 tester.partition()
    212  212 |             else:
    213  213 |                 tester.to_edge_transform_and_lower()
    213      |-                tester.check_count({"torch.ops.higher_order.executorch_call_delegate": 1})
         214 |+                tester.check_count(
         215 |+                    {"torch.ops.higher_order.executorch_call_delegate": 1}
         216 |+                )
    215  217 |                 tester.to_executorch()
    216  218 |                 tester.serialize()
    217  219 |                 tester.run_method_and_compare_outputs()
--------------------------------------------------------------------------------
    261  263 |             tester.to_executorch()
    262  264 |             tester.serialize()
    263  265 |             tester.run_method_and_compare_outputs()
    263      |-        

looks like a linter issue

@cbilgin
Copy link
Author

cbilgin commented Nov 17, 2024

@mcr229 fixed the linter issues I think.

@github-actions
Copy link

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

@github-actions github-actions bot added the stale PRs inactive for over 60 days label Aug 29, 2025
@github-actions
Copy link

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. stale PRs inactive for over 60 days

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants