Fix erroneous extension_features initialization
#6936
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: ## Context Some devices were hanging when trying to run Vulkan due to a bug in pytorch#6910. The issue is that `extension_features` was being initialized with `&shader_float16_int8_types` before `shader_float16_int8_types` was initialized. ## Changes This diff fixes the bug and changes extension_features to set to an appropriate value based on which extensions are available according to the vulkan headers being used. Differential Revision: D66118505
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6936
Note: Links to docs will display an error until the docs builds have been completed. ❗ 2 Active SEVsThere are 2 currently active SEVs. If your PR is affected, please view them below:
✅ No FailuresAs of commit c5fb979 with merge base ee74d06 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D66118505 |
junpi3
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Context
Some devices were hanging when trying to run Vulkan due to a bug in #6910.
The issue is that
extension_featureswas being initialized with&shader_float16_int8_typesbeforeshader_float16_int8_typeswas initialized.Changes
This diff fixes the bug and changes extension_features to set to an appropriate value based on which extensions are available according to the vulkan headers being used.
Differential Revision: D66118505