Skip to content

Update getting-started-setup.md #7027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Update getting-started-setup.md #7027

wants to merge 1 commit into from

Conversation

@kirklandsign
Copy link
Contributor

@kirklandsign kirklandsign commented Nov 22, 2024

Summary

Should cd to root before running cmake

Test plan

Run these commands

@kirklandsign kirklandsign added the module: doc Issues related to documentation, both in docs/ and inlined in code label Nov 22, 2024
@kirklandsign kirklandsign requested a review from dbort November 22, 2024 01:58
@pytorch-bot
Copy link

pytorch-bot bot commented Nov 22, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7027

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 1 New Failure

As of commit 04b02b7 with merge base 97b58bb (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 22, 2024
@github-actions
Copy link

github-actions bot commented Nov 22, 2024

This PR needs a release notes: label

If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

dbort
dbort reviewed Jan 16, 2025
View reviewed changes
docs/source/getting-started-setup.md
# Clean and configure the CMake build system. Compiled programs will
# appear in the executorch/cmake-out directory we create here.
(rm -rf cmake-out && mkdir cmake-out && cd cmake-out && cmake ..)
(rm -rf cmake-out && mkdir cmake-out && cd cmake-out && cmake .. && cd ..)
Copy link
Contributor

@dbort dbort Jan 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't necessary since it's in a subshell (the parentheses). That's why I put this in parens, because it won't affect the current directory of the parent shell

@kirklandsign kirklandsign deleted the kirklandsign-patch-1 branch March 10, 2025 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dbort dbort dbort left review comments

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: doc Issues related to documentation, both in docs/ and inlined in code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kirklandsign @dbort @facebook-github-bot