Skip to content

Buckify op_add for FusionG3 and add cxx tests. #7102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 3, 2024
Merged

Buckify op_add for FusionG3 and add cxx tests. #7102

merged 1 commit into from
Dec 3, 2024

Conversation

@hsharma35
Copy link
Contributor

@hsharma35 hsharma35 commented Nov 27, 2024

Differential Revision: D66532566

@pytorch-bot
Copy link

pytorch-bot bot commented Nov 27, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7102

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures

As of commit 52ddaaa with merge base 13a1a30 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 27, 2024
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Nov 27, 2024

This pull request was exported from Phabricator. Differential Revision: D66532566

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Dec 3, 2024

This pull request was exported from Phabricator. Differential Revision: D66532566

@hsharma35
Copy link
Contributor Author

hsharma35 commented Dec 3, 2024

@pytorchbot label "topic: not user facing"

@hsharma35 hsharma35 requested a review from zonglinpeng December 3, 2024 18:41
zonglinpeng
zonglinpeng approved these changes Dec 3, 2024
View reviewed changes
Copy link
Contributor

@zonglinpeng zonglinpeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for adding the actual unit test per op!

can you please add cmake files and instructions to run the test under Cadence readme as a new sub-topic, e.g Cadence G3

zonglinpeng
zonglinpeng reviewed Dec 3, 2024
View reviewed changes
backends/cadence/fusion_g3/operators/tests/test_op_add.cpp
Tensor out = tf.zeros(sizes);

// Add two 2x2 tensors.
add_out(tf.make(sizes, {1, 2, 3, 4}), tf.make(sizes, {2, 2, 2, 2}), 1, out);
Copy link
Contributor

@zonglinpeng zonglinpeng Dec 3, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a way to parameterize the test inputs for multiple shapes?

@hsharma35 @facebook-github-bot
Buckify op_add for FusionG3 and add cxx tests. (pytorch#7102)
52ddaaa 
Summary:

Minimal buckification for `op_add` with some tests to reproduce failures.

Reviewed By: zonglinpeng

Differential Revision: D66532566
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Dec 3, 2024

This pull request was exported from Phabricator. Differential Revision: D66532566

@facebook-github-bot facebook-github-bot merged commit 5635672 into pytorch:main Dec 3, 2024
38 of 43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zonglinpeng zonglinpeng zonglinpeng approved these changes

@mcremon-meta mcremon-meta Awaiting requested review from mcremon-meta

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported topic: not user facing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hsharma35 @facebook-github-bot @zonglinpeng