Be able to compile in offline mode #7305
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7305
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 1 Unrelated FailureAs of commit 653ccc8 with merge base e1d1a96 ( NEW FAILURE - The following job has failed:
FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
mergennachin
added
the
release notes: build
Contributor
Author
|
Corresponding GH issue: #7306 |
mergennachin
force-pushed
the
my-fork3
branch
from
fe2f1e6 to
98bf2f4
Compare
mergennachin
force-pushed
the
my-fork3
branch
from
98bf2f4 to
653ccc8
Compare
tarun292
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently, during compilation via cmake, we can't do it in offline environments (e.g., doing development in airplane) for instance.
There are two things we can do:
Currently, we are downloading buck2 from the internet. This is fine, but we're downloading every time we
rm -rf cmake-outfile. Let's just download once and save insideexecutorch/buck2-bin/folder directly instead ofexecutorch/cmake-out/buck2-bin/. That way, you will most likely have the necessary buck2 binary downloaded/cached and rarely deleted. There's little reason to delete this directory.FXDiv is getting downloaded if it is not defined. https://github.com/google/XNNPACK/blob/effe4ca0631f3fb0dac9551dab6f1d8a2eaabba2/CMakeLists.txt#L355. However, this is an oversight, since we actually have it already (https://github.com/pytorch/executorch/blob/main/.gitmodules#L19), just haven't set the environment variable appropriately.
Test plan
(mkdir cmake-out && cd cmake-out && cmake ..)