Fix errors in comparison functions when dtype is uint8 #7313
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7313
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 63955df with merge base 6941d46 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D67163600 |
|
@pytorchbot label "topic: not user facing" |
|
This pull request was exported from Phabricator. Differential Revision: D67163600 |
Olivia-liu
approved these changes
Dec 13, 2024
|
This pull request was exported from Phabricator. Differential Revision: D67163600 |
Summary: Fixed error in comparison functions that were producing wrong results with uint8 dtype. Reviewed By: Olivia-liu Differential Revision: D67163600
YIWENX14
force-pushed
the
export-D67163600
branch
from
9893577 to
63955df
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67163600 |
Olivia-liu
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Fixed error in comparison functions that were producing wrong results with uint8 dtype.
Differential Revision: D67163600