Skip to content

Conversation

@digantdesai
Copy link
Contributor

Reverts some more commits to get the diff-train moving again.

@digantdesai digantdesai requested a review from iseeyuan December 18, 2024 05:50
@pytorch-bot
Copy link

pytorch-bot bot commented Dec 18, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7353

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 4959202 with merge base 11beed1 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 18, 2024
@digantdesai digantdesai changed the title [Arm\ Fix merge conflicts after previous reverts [Arm] Fix merge conflicts after previous reverts Dec 18, 2024
This reverts commit bb07cad.

Signed-off-by: Digant Desai <[email protected]>
@digantdesai digantdesai merged commit 44e31fb into main Dec 18, 2024
44 checks passed
@digantdesai digantdesai deleted the arm_revert_2 branch December 18, 2024 16:05
per added a commit to per/executorch that referenced this pull request Dec 19, 2024
This reverts commit 44e31fb.

Change-Id: I12d88419e45a800e43e1e31d21280bc3b63710c6
per added a commit to per/executorch that referenced this pull request Dec 19, 2024
This reverts commit 44e31fb.

Change-Id: I12d88419e45a800e43e1e31d21280bc3b63710c6
digantdesai pushed a commit that referenced this pull request Dec 20, 2024
)

* Revert "[Arm] Fix merge conflicts after previous reverts (#7353)"

This reverts commit 44e31fb.

Change-Id: I12d88419e45a800e43e1e31d21280bc3b63710c6

* Revert "Revert "Add full operator to fold dq/q handling" (#7351)"

This reverts commit 11beed1.

Change-Id: I6ba9b37f069c3ad819114fe1384659bc0f68135f

* Fix type checker issues

Signed-off-by: Per Åstrand <[email protected]>
Change-Id: Iee35eeb4af28a037848570b1d5143380222f549d

* Address pyre checks from Meta internal tools

Signed-off-by: Per Åstrand <[email protected]>
Change-Id: I60fb32ad55a3f6d3617993481ab0c1ed46cf778c

* Fix more typecheckings

Change-Id: I37fb7468b5cb040b916fabb2784ec475318bddba

* Reapply pyre-ignores after lintrunner moves

lintrunner moved the pyre-ignores to the wrong line, re-apply to the
right line again.

Signed-off-by: Per Åstrand <[email protected]>
Change-Id: Icbb6cf6f2d65d6fe1c00e7c4a738691ffeb7acb2

---------

Signed-off-by: Per Åstrand <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: not user facing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants