Break out utils of setup.sh #7777
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Erik-Lundell
added
partner: arm
facebook-github-bot
added
the
CLA Signed
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7777
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New Failures, 1 Unrelated FailureAs of commit 9358101 with merge base 4e63f0e ( NEW FAILURES - The following jobs have failed:
BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Collaborator
Author
|
Failing jobs unrelated. |
zingo
approved these changes
Jan 21, 2025
digantdesai
approved these changes
Jan 21, 2025
The two bash function verify_md5 and patch_repo are put in a separate util.sh for when they need to be called from other setup flows. Change-Id: Ifce8e138e1cb74f71cff5bf40e8ec9afac500e95
Erik-Lundell
force-pushed
the
break-out-utils
branch
from
b29960a to
51b88d9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a start of modularizing the setup.sh script. By breaking out utils, we get more flexibility for accessing them changing how dependencies are handled.
cc @digantdesai @freddan80 @per @zingo @oscarandersson8218