Arm backend: enable dim_order #7831
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With edge_compile_config.skip_dim_order = True removed, to_copy will be converted into to_dim_order_copy nodes. This commit moves our logic from to_copy into to_dim_order_copy. Signed-off-by: Oscar Andersson <[email protected]> Change-Id: I46a30cd88125f3e2e26810352a1e0626bd5cce4a
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7831
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New Failures, 1 Cancelled JobAs of commit 991d96f with merge base 91f09aa ( NEW FAILURES - The following jobs have failed:
CANCELLED JOB - The following job was cancelled. Please retry:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
oscarandersson8218
added
partner: arm
facebook-github-bot
added
the
CLA Signed
zingo
approved these changes
Jan 22, 2025
digantdesai
reviewed
Jan 22, 2025
| @register_tosa_support_check | ||
| class ToCopySupported(SupportedTOSAOperatorCheck): | ||
| targets = [exir_ops.edge.aten._to_copy.default] | ||
| targets = [ |
Contributor
There was a problem hiding this comment.
I guess we don't lower empty?
Collaborator
Author
There was a problem hiding this comment.
Not as of today.
digantdesai
approved these changes
Jan 22, 2025
Collaborator
|
Failing test seem unrealted to PR and fails on other PR's also. |
Contributor
|
@pytorchbot cherry-pick --onto release/0.5 -c fixnewfeature |
pytorchbot
pushed a commit
that referenced
this pull request
Jan 24, 2025
Add support for to_dim_order_copy With edge_compile_config.skip_dim_order = True removed, to_copy will be converted into to_dim_order_copy nodes. This commit moves our logic from to_copy into to_dim_order_copy. Signed-off-by: Oscar Andersson <[email protected]> (cherry picked from commit 135e875)
Collaborator
Cherry picking #7831The cherry pick PR is at #7952 and it is recommended to link a fixnewfeature cherry pick PR with an issue. The following tracker issues are updated: Details for Dev Infra teamRaised by workflow job |
SS-JIA
pushed a commit
that referenced
this pull request
Jan 27, 2025
Arm backend: enable dim_order (#7831) Add support for to_dim_order_copy With edge_compile_config.skip_dim_order = True removed, to_copy will be converted into to_dim_order_copy nodes. This commit moves our logic from to_copy into to_dim_order_copy. Signed-off-by: Oscar Andersson <[email protected]> (cherry picked from commit 135e875) Co-authored-by: Oscar Andersson <[email protected]>
YIWENX14
pushed a commit
that referenced
this pull request
Jan 28, 2025
Add support for to_dim_order_copy With edge_compile_config.skip_dim_order = True removed, to_copy will be converted into to_dim_order_copy nodes. This commit moves our logic from to_copy into to_dim_order_copy. Signed-off-by: Oscar Andersson <[email protected]>
zonglinpeng
pushed a commit
to zonglinpeng/executorch
that referenced
this pull request
Jan 30, 2025
Add support for to_dim_order_copy With edge_compile_config.skip_dim_order = True removed, to_copy will be converted into to_dim_order_copy nodes. This commit moves our logic from to_copy into to_dim_order_copy. Signed-off-by: Oscar Andersson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Removes edge_compile_config.skip_dim_order = True which means that to_copy will be converted into to_dim_order_copy nodes. This commit adds support for to_dim_order_copy.
Change-Id: I46a30cd88125f3e2e26810352a1e0626bd5cce4a
cc @digantdesai @freddan80 @per @zingo