Use the proper offset for front_cursor in flatcc emitter #7933
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7933
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 96f4b6a with merge base e52b3fc ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D68502867 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Jan 24, 2025
Summary: Updating the front_cursor pointer in the ETDumpGen class to point to the correct location in the buffer, and adding a check to ensure that the buffer size provided is greater than the minimum required size. This fixes a long running issue that the Turing team was running into when generating ETDump's for large models. The etdump_test.cpp file has been updated to use a smaller buffer size for testing purposes and we do more stress testing. Differential Revision: D68502867
facebook-github-bot
force-pushed
the
export-D68502867
branch
from
3728a99 to
f29bc81
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D68502867 |
Gasoonjia
approved these changes
Jan 24, 2025
Summary: Updating the front_cursor pointer in the ETDumpGen class to point to the correct location in the buffer, and adding a check to ensure that the buffer size provided is greater than the minimum required size. This fixes a long running issue that the Turing team was running into when generating ETDump's for large models. The etdump_test.cpp file has been updated to use a smaller buffer size for testing purposes and we do more stress testing. Reviewed By: Gasoonjia Differential Revision: D68502867
facebook-github-bot
force-pushed
the
export-D68502867
branch
from
f29bc81 to
96f4b6a
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D68502867 |
YIWENX14
pushed a commit
that referenced
this pull request
Jan 28, 2025
Differential Revision: D68502867 Pull Request resolved: #7933
zonglinpeng
pushed a commit
to zonglinpeng/executorch
that referenced
this pull request
Jan 30, 2025
Differential Revision: D68502867 Pull Request resolved: pytorch#7933
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differential Revision: D68502867