Skip to content

Conversation

@hsharma35
Copy link
Contributor

Summary: Add option to specify constant methods in export.

Differential Revision: D68637824

@pytorch-bot
Copy link

pytorch-bot bot commented Jan 24, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7948

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit dccb218 with merge base e52b3fc (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 24, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68637824

hsharma35 added a commit to hsharma35/executorch that referenced this pull request Jan 24, 2025
Summary:

Add option to specify constant methods in export. The constants show up as methods (similar to "forward") in the serialized .pte.

Differential Revision: D68637824
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68637824

import logging
from pathlib import Path
from typing import Callable, cast, Optional
from typing import Any, Callable, cast, Optional
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use object than Any

hsharma35 added a commit to hsharma35/executorch that referenced this pull request Jan 24, 2025
Summary:

Add option to specify constant methods in export. The constants show up as methods (similar to "forward") in the serialized .pte.

Reviewed By: zonglinpeng

Differential Revision: D68637824
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68637824

Summary:

Add option to specify constant methods in export. The constants show up as methods (similar to "forward") in the serialized .pte.

Reviewed By: zonglinpeng

Differential Revision: D68637824
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68637824

@facebook-github-bot facebook-github-bot merged commit e78ed83 into pytorch:main Jan 25, 2025
46 of 47 checks passed
YIWENX14 pushed a commit that referenced this pull request Jan 28, 2025
Differential Revision: D68637824

Pull Request resolved: #7948
zonglinpeng pushed a commit to zonglinpeng/executorch that referenced this pull request Jan 30, 2025
Differential Revision: D68637824

Pull Request resolved: pytorch#7948
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported topic: not user facing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants