Remove unused Empty Tensors from Edge Graph #7954
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Following up on this post: https://fb.workplace.com/groups/pytorch.edge.users/permalink/1683417975861822/ It seems like empty tensors aren't necessary in some ops, like concatenation. We should remove these as inputs in the edge graphs to make it easier to deal with. Reviewed By: digantdesai Differential Revision: D68589336
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7954
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 9a6b75b with merge base b522084 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D68589336 |
mcr229
force-pushed
the
export-D68589336
branch
from
34aff36 to
c4c187a
Compare
Contributor
|
@mcr229 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
lucylq
approved these changes
Jan 25, 2025
kirklandsign
approved these changes
Jan 27, 2025
Contributor
|
@mcr229 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
YIWENX14
pushed a commit
that referenced
this pull request
Jan 28, 2025
Differential Revision: D68589336 Pull Request resolved: #7954
zonglinpeng
pushed a commit
to zonglinpeng/executorch
that referenced
this pull request
Jan 30, 2025
Differential Revision: D68589336 Pull Request resolved: pytorch#7954
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Following up on this post:
https://fb.workplace.com/groups/pytorch.edge.users/permalink/1683417975861822/
It seems like empty tensors aren't necessary in some ops, like concatenation. We should remove these as inputs in the edge graphs to make it easier to deal with.
Reviewed By: digantdesai
Differential Revision: D68589336