Add view_copy/static_reshape support to XNNPACK delegate #7959
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GregoryComer
added
the
release notes: xnnpack
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7959
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 7ceda56 with merge base 8af8252 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
GregoryComer
force-pushed
the
xnn-reshape
branch
from
00f33af to
c90d182
Compare
GregoryComer
commented
Jan 26, 2025
GregoryComer
commented
Jan 26, 2025
GregoryComer
commented
Jan 26, 2025
GregoryComer
commented
Jan 26, 2025
GregoryComer
force-pushed
the
xnn-reshape
branch
from
c90d182 to
36bdc16
Compare
Contributor
|
@GregoryComer has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
GregoryComer
commented
Jan 27, 2025
GregoryComer
force-pushed
the
xnn-reshape
branch
from
bbc17ca to
36bdc16
Compare
GregoryComer
force-pushed
the
xnn-reshape
branch
from
36bdc16 to
cf00810
Compare
digantdesai
approved these changes
Jan 27, 2025
|
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
|
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
GregoryComer
added a commit
to GregoryComer/executorch
that referenced
this pull request
Nov 15, 2025
Summary: Add support for delegating view_copy in the XNNPACK delegate via the XNN static_reshape operator. This includes support for up to one dynamic dimension. It also includes conditional support for NHWC, so long as batch and channel are fixed (if batch or channel is modified, the reshape has to be done in the native dim order). Test Plan: I've added test coverage for view_copy, including dynamic shape support and practitioner constraints, to backends/xnnpack/test/ops/test_view_copy.py.If also added additional tests to cover the new view logic in channels_last_tagged_reshape_pass. Differential Revision: D68691788 Pulled By: GregoryComer
GregoryComer
force-pushed
the
xnn-reshape
branch
from
cf00810 to
85729d2
Compare
GregoryComer
requested review from
JacobSzwejbka,
kimishpatel and
larryliu0820
as code owners
|
@GregoryComer has exported this pull request. If you are a Meta employee, you can view the originating Diff in D68691788. |
GregoryComer
force-pushed
the
xnn-reshape
branch
from
85729d2 to
afd7f88
Compare
GregoryComer
added a commit
to GregoryComer/executorch
that referenced
this pull request
Dec 4, 2025
Summary: Add support for delegating view_copy in the XNNPACK delegate via the XNN static_reshape operator. This includes support for up to one dynamic dimension. It also includes conditional support for NHWC, so long as batch and channel are fixed (if batch or channel is modified, the reshape has to be done in the native dim order). Pull Request resolved: pytorch#7959 Test Plan: I've added test coverage for view_copy, including dynamic shape support and practitioner constraints, to backends/xnnpack/test/ops/test_view_copy.py.If also added additional tests to cover the new view logic in channels_last_tagged_reshape_pass. Differential Revision: D68691788 Pulled By: GregoryComer
GregoryComer
added a commit
to GregoryComer/executorch
that referenced
this pull request
Dec 4, 2025
Summary: Add support for delegating view_copy in the XNNPACK delegate via the XNN static_reshape operator. This includes support for up to one dynamic dimension. It also includes conditional support for NHWC, so long as batch and channel are fixed (if batch or channel is modified, the reshape has to be done in the native dim order). Test Plan: I've added test coverage for view_copy, including dynamic shape support and practitioner constraints, to backends/xnnpack/test/ops/test_view_copy.py.If also added additional tests to cover the new view logic in channels_last_tagged_reshape_pass. Differential Revision: D68691788 Pulled By: GregoryComer
GregoryComer
force-pushed
the
xnn-reshape
branch
from
afd7f88 to
f24084f
Compare
GregoryComer
added a commit
to GregoryComer/executorch
that referenced
this pull request
Dec 4, 2025
Summary: Add support for delegating view_copy in the XNNPACK delegate via the XNN static_reshape operator. This includes support for up to one dynamic dimension. It also includes conditional support for NHWC, so long as batch and channel are fixed (if batch or channel is modified, the reshape has to be done in the native dim order). Test Plan: I've added test coverage for view_copy, including dynamic shape support and practitioner constraints, to backends/xnnpack/test/ops/test_view_copy.py.If also added additional tests to cover the new view logic in channels_last_tagged_reshape_pass. Differential Revision: D68691788 Pulled By: GregoryComer
GregoryComer
force-pushed
the
xnn-reshape
branch
from
f24084f to
5922f58
Compare
GregoryComer
added a commit
to GregoryComer/executorch
that referenced
this pull request
Dec 4, 2025
Summary: Add support for delegating view_copy in the XNNPACK delegate via the XNN static_reshape operator. This includes support for up to one dynamic dimension. It also includes conditional support for NHWC, so long as batch and channel are fixed (if batch or channel is modified, the reshape has to be done in the native dim order). Test Plan: I've added test coverage for view_copy, including dynamic shape support and practitioner constraints, to backends/xnnpack/test/ops/test_view_copy.py.If also added additional tests to cover the new view logic in channels_last_tagged_reshape_pass. Differential Revision: D68691788 Pulled By: GregoryComer
GregoryComer
force-pushed
the
xnn-reshape
branch
from
5922f58 to
1c7bcf2
Compare
GregoryComer
added a commit
to GregoryComer/executorch
that referenced
this pull request
Dec 4, 2025
Summary: Add support for delegating view_copy in the XNNPACK delegate via the XNN static_reshape operator. This includes support for up to one dynamic dimension. It also includes conditional support for NHWC, so long as batch and channel are fixed (if batch or channel is modified, the reshape has to be done in the native dim order). Test Plan: I've added test coverage for view_copy, including dynamic shape support and practitioner constraints, to backends/xnnpack/test/ops/test_view_copy.py.If also added additional tests to cover the new view logic in channels_last_tagged_reshape_pass. Differential Revision: D68691788 Pulled By: GregoryComer
GregoryComer
force-pushed
the
xnn-reshape
branch
from
1c7bcf2 to
918a5fe
Compare
Summary: Add support for delegating view_copy in the XNNPACK delegate via the XNN static_reshape operator. This includes support for up to one dynamic dimension. It also includes conditional support for NHWC, so long as batch and channel are fixed (if batch or channel is modified, the reshape has to be done in the native dim order). Test Plan: I've added test coverage for view_copy, including dynamic shape support and practitioner constraints, to backends/xnnpack/test/ops/test_view_copy.py.If also added additional tests to cover the new view logic in channels_last_tagged_reshape_pass. Differential Revision: D68691788 Pulled By: GregoryComer
GregoryComer
force-pushed
the
xnn-reshape
branch
from
918a5fe to
7ceda56
Compare
|
@GregoryComer has imported this pull request. If you are a Meta employee, you can view this in D68691788. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add support for delegating view_copy in the XNNPACK delegate via the XNN static_reshape operator. This includes support for up to one dynamic dimension. It also includes conditional support for NHWC, so long as batch and channel are fixed (if batch or channel is modified, the reshape has to be done in the native dim order).
Add support for delegating view_copy in the XNNPACK delegate via the XNN static_reshape operator. This includes support for up to one dynamic dimension.
Test plan
I've added test coverage for view_copy, including dynamic shape support and practitioner constraints, to backends/xnnpack/test/ops/test_view_copy.py.If also added additional tests to cover the new view logic in channels_last_tagged_reshape_pass.