-
Notifications
You must be signed in to change notification settings - Fork 751
Conditionally support expand_copy in XNNPACK delegate #7960
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7960
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 144b550 with merge base d886373 ( BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
a1ba74c to
7ce711f
Compare
mcr229
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good let's just address those comments
|
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
|
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
7ce711f to
7c87a4e
Compare
7c87a4e to
679a5c4
Compare
679a5c4 to
144b550
Compare
Summary
Expand is sometimes used to to express an unsqueeze operation (inserting singleton dims) - one motivating example is in MobileBERT (link). This PR allows XNNPACK to conditionally lower expand_copy, as long as the expand is used solely to add singleton dimensions.
Test plan
Added test coverage in
backends/xnnpack/test/ops/test_expand.py.