From 649c5940974f60b6bf30c0caf14670a3199db8dc Mon Sep 17 00:00:00 2001 From: Per Held Date: Fri, 10 Jan 2025 14:02:46 +0100 Subject: [PATCH 1/3] Arm backend: Fix mypy warnings in arm_vela.py In arm_vela.py, function vela_compile() there is a reuse of the variable block_length that was of different type between uses and mypy complained. Change name of block_length that is used inside the loop to block_length_bytes since its not a int. Change-Id: If44e46269f777df903641f1cd4c30af4c60d5bbc --- backends/arm/arm_vela.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/backends/arm/arm_vela.py b/backends/arm/arm_vela.py index ef0336147af..f7f0c4b49cc 100644 --- a/backends/arm/arm_vela.py +++ b/backends/arm/arm_vela.py @@ -96,13 +96,13 @@ def vela_compile(tosa_graph, args: List[str], shape_order=None): block_name = block_name + b"\x00" * (16 - len(block_name)) # We need the acual unpadded block lengths for hw setup - block_length = struct.pack(" Date: Mon, 13 Jan 2025 09:45:02 +0100 Subject: [PATCH 2/3] Arm backend: Fix mypy warnings in arm_model_eval Fix mypy warnings in arm_model_evaluator.py Change-Id: Ife2e5502d5dacd71e92bd5a86fdf25a34b0fd2b6 --- backends/arm/util/arm_model_evaluator.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/backends/arm/util/arm_model_evaluator.py b/backends/arm/util/arm_model_evaluator.py index b43c781dfdf..e13f9c4df03 100644 --- a/backends/arm/util/arm_model_evaluator.py +++ b/backends/arm/util/arm_model_evaluator.py @@ -59,7 +59,7 @@ def __init__( if tosa_output_path: self.tosa_output_path = tosa_output_path else: - self.tosa_output_path = None # type: ignore[assignment] + self.tosa_output_path = "" def get_model_error(self) -> defaultdict: """ @@ -104,7 +104,7 @@ def get_compression_ratio(self) -> float: return compression_ratio - def evaluate(self) -> dict[Any]: # type: ignore[type-arg] + def evaluate(self) -> dict[str, Any]: model_error_dict = self.get_model_error() output_metrics = {"name": self.model_name, "metrics": dict(model_error_dict)} From e7d4c09440f20e744bb531a3400ae2bc23bd3d50 Mon Sep 17 00:00:00 2001 From: Per Held Date: Mon, 13 Jan 2025 09:58:59 +0100 Subject: [PATCH 3/3] Arm backend: Fix mypy warnings in node_visitor.py Annotate a dict to fix mypy warning. Change-Id: Icbe9f846ecddcf974c47f355c36df63b9ea8f593 --- backends/arm/operators/node_visitor.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/backends/arm/operators/node_visitor.py b/backends/arm/operators/node_visitor.py index b8fd09ea98c..afb5f93baa7 100644 --- a/backends/arm/operators/node_visitor.py +++ b/backends/arm/operators/node_visitor.py @@ -44,7 +44,7 @@ def define_node( # container for all node visitors -_node_visitor_dicts = { # type: ignore[var-annotated] +_node_visitor_dicts: Dict[TosaSpecification, Dict] = { TosaSpecification.create_from_string("TOSA-0.80+BI"): {}, TosaSpecification.create_from_string("TOSA-0.80+MI"): {}, }