Skip to content

Conversation

@SaoirseARM
Copy link
Collaborator

@SaoirseARM SaoirseARM commented Feb 10, 2025

Summary

  • In decompose_select.py - a squeeze op is used to get final output shape. If we squeeze using the input rank and batch_size==1 this dimension will also be removed.
  • Changed this to only squeeze on dimension selected.

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218

- If we squeeze using the input rank and batch_size==1 this dimension will also be removed.
@pytorch-bot
Copy link

pytorch-bot bot commented Feb 10, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8335

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 1 Pending, 2 Unrelated Failures

As of commit 5866ca7 with merge base 524ec78 (image):

NEW FAILURE - The following job has failed:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

BROKEN TRUNK - The following job failed but was present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 10, 2025
@SaoirseARM
Copy link
Collaborator Author

@pytorchbot label ciflow/trunk

@SaoirseARM
Copy link
Collaborator Author

@pytorchbot label 'partner: arm'

@pytorch-bot pytorch-bot bot added the partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm label Feb 10, 2025
@SaoirseARM
Copy link
Collaborator Author

@pytorchbot label "topic: not user facing"

@zingo
Copy link
Collaborator

zingo commented Feb 10, 2025

MacOS fails are unrelated

@zingo zingo merged commit 9746ce7 into pytorch:main Feb 10, 2025
104 of 112 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm topic: not user facing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants