Minor improvements in Arm testing. #8337
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the if statment looking for executorch_call_delegates fails, the delegate can run the model in eager mode and still produce correct results without the user noticing. We need to make sure we actually run the reference model. Change-Id: I5fe070338e65e3e253cd319202b61fb4b389fde4
Change-Id: I27404d649c5e9945b319857f1f008cbfe06d20aa
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8337
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 Cancelled JobsAs of commit 57bc715 with merge base 524ec78 ( CANCELLED JOBS - The following jobs were cancelled. Please retry:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
Erik-Lundell
added
ciflow/trunk
partner: arm
facebook-github-bot
added
the
CLA Signed
zingo
approved these changes
Feb 10, 2025
Collaborator
|
MacOs fails unrelated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add markers to flaky tests
Check that reference model was run in TosaReferenceModelDispatch
If the if statment looking for executorch_call_delegates fails,
the delegate can run the model in eager mode and still produce correct results
without the user noticing. We need to make sure we actually run the reference model.
cc @digantdesai @freddan80 @per @zingo @oscarandersson8218