Add additional checks for operator support. #8367
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This seems to match the intention of OperatorSupportBase and increases the flexibility of our support flow. New checks if different kinds are simply added to `tosa_support_factory` Signed-off-by: Erik Lundell <[email protected]> Change-Id: I4f5f1669959f35c5e2770da396a352e1730cb3e0
This can be used to avoid partitioning parts of a model when debugging. Though any OperatorSupportBase can be used, we add three OperatorSupport as utilities: DontPartition: Don't partition based on node target DontPartitionName: Don't partition based on node name DontPartitionModule: Don't partition based on which module the op comes from. All these checks can match parts of the target name, and save a list of the nodes they reject for debugging. Signed-off-by: Erik Lundell <[email protected]> Change-Id: I0b2537370da4aadcffbb87c52cb98e82d78cf27f
Erik-Lundell
added
partner: arm
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8367
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 Cancelled Job, 1 PendingAs of commit 2584dc4 with merge base 8d96d74 ( CANCELLED JOB - The following job was cancelled. Please retry:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
zingo
approved these changes
Feb 11, 2025
Collaborator
|
MacOs fails unrelated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can be used to avoid partitioning parts
of a model when debugging.
Though any OperatorSupportBase can be used, we add three OperatorSupport as utilities:
All these checks can match parts of the target name, and save a list of the nodes they reject for debugging.
cc @digantdesai @freddan80 @per @zingo @oscarandersson8218