Skip to content

Conversation

@cccclai
Copy link
Contributor

@cccclai cccclai commented Mar 4, 2025

Differential Revision: D70542319

get the commit from https://hud2.pytorch.org/hud/pytorch/pytorch/nightly/0

@pytorch-bot
Copy link

pytorch-bot bot commented Mar 4, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8922

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit baac153 with merge base 6346348 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 4, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D70542319

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D70542319

@cccclai cccclai force-pushed the export-D70542319 branch 2 times, most recently from 09d9081 to b20fc92 Compare March 5, 2025 19:05
cccclai added a commit to cccclai/executorch-1 that referenced this pull request Mar 5, 2025
Summary: Pull Request resolved: pytorch#8922

Differential Revision: D70542319
Summary: Pull Request resolved: pytorch#8922

Differential Revision: D70542319
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D70542319

@swolchok
Copy link
Contributor

swolchok commented Mar 5, 2025

unittest-editable timing out on Mac is concerning. it was just during build so hopefully it was just a flake; reran it.

if tests pass, let's ship it

Copy link
Contributor

@swolchok swolchok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whynot

@cccclai
Copy link
Contributor Author

cccclai commented Mar 6, 2025

Add trunk job for more tests coverage

@cccclai cccclai merged commit 73740e9 into pytorch:main Mar 6, 2025
167 of 170 checks passed
zonglinpeng pushed a commit that referenced this pull request Mar 6, 2025
bump pytorch version (#8922)

Summary: Pull Request resolved: #8922

Differential Revision: D70542319
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported topic: not user facing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants