[ET-VK] Shortening code for slice op when packed dim is not the same as slice dim. #9136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…as slice dim. This diff is a code change for the Slice op to shorten its code when packed dimension is not the same as the slice dimension. Differential Revision: [D70737264](https://our.internmc.facebook.com/intern/diff/D70737264/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9136
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 380e6a7 with merge base e763a83 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
This was referenced Mar 11, 2025
|
This pull request was exported from Phabricator. Differential Revision: D70737264 |
SS-JIA
approved these changes
Mar 11, 2025
yipjustin
approved these changes
Mar 11, 2025
…t the same as slice dim." This diff is a code change for the Slice op to shorten its code when packed dimension is not the same as the slice dimension. Differential Revision: [D70737264](https://our.internmc.facebook.com/intern/diff/D70737264/) [ghstack-poisoned]
…t the same as slice dim." This diff is a code change for the Slice op to shorten its code when packed dimension is not the same as the slice dimension. Differential Revision: [D70737264](https://our.internmc.facebook.com/intern/diff/D70737264/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D70737264 |
facebook-github-bot
merged commit 525d247
into
gh/trivedivivek/59/base
52 checks passed
facebook-github-bot
temporarily deployed
to
cherry-pick-bot
GitHub Actions
Inactive
SS-JIA
pushed a commit
that referenced
this pull request
Mar 11, 2025
…as slice dim. (#9169) This PR was created by the merge bot to help merge the original PR into the main branch. ghstack PR number: #9136 by @trivedivivek ^ Please use this as the source of truth for the PR details, comments, and reviews ghstack PR base: https://github.com/pytorch/executorch/tree/gh/trivedivivek/59/base ghstack PR head: https://github.com/pytorch/executorch/tree/gh/trivedivivek/59/head Merge bot PR base: https://github.com/pytorch/executorch/tree/main Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/trivedivivek/59/orig @diff-train-skip-merge Co-authored-by: Vivek Trivedi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
This diff is a code change for the Slice op to shorten its code when packed dimension is not the same as the slice dimension.
Differential Revision: D70737264