Skip to content

Add arm64 size_test #9252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
mergennachin wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Add arm64 size_test #9252

mergennachin wants to merge 1 commit into from

Conversation

@mergennachin
Copy link
Contributor

@mergennachin mergennachin commented Mar 14, 2025

No description provided.

@pytorch-bot
Copy link

pytorch-bot bot commented Mar 14, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9252

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit b843749 with merge base b158753 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 14, 2025
@mergennachin mergennachin requested a review from swolchok March 14, 2025 00:43
@mergennachin
Copy link
Contributor Author

mergennachin commented Mar 14, 2025 •
edited
Loading

Hmm.. compilation is failing for arm64. Probably a good thing we caught this.

https://github.com/pytorch/executorch/actions/runs/13847352135/job/38748447351?pr=9252

FWIW, the other two are succeeding:

https://github.com/pytorch/executorch/actions/runs/13847352135/job/38748444523?pr=9252

https://github.com/pytorch/executorch/actions/runs/13847352135/job/38748444854?pr=9252

@swolchok
Copy link
Contributor

swolchok commented Mar 14, 2025

Hmm.. compilation is failing for arm64. Probably a good thing we caught this.

https://github.com/pytorch/executorch/actions/runs/13847352135/job/38748447351?pr=9252

FWIW, the other two are succeeding:

https://github.com/pytorch/executorch/actions/runs/13847352135/job/38748444523?pr=9252

https://github.com/pytorch/executorch/actions/runs/13847352135/job/38748444854?pr=9252

looks like it might be a false positive. see e.g. microsoft/onnxruntime#19296 . I don't see a problem offhand looking at the code, do you?

swolchok
swolchok approved these changes Mar 14, 2025
View reviewed changes
.github/workflows/pull.yml Outdated
# threshold=48120 on devserver with gcc11.4
# todo(lfq): update once binary size is below 50kb.
threshold="51784"
threshold="51504"
Copy link
Contributor

@swolchok swolchok Mar 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's awkward that we have the same threshold for two different CPU architectures, but this is still an incremental improvement

@mergennachin mergennachin force-pushed the size_test branch 3 times, most recently from b965f38 to 23fc5c1 Compare March 27, 2025 15:46
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Mar 27, 2025

@mergennachin has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@mergennachin mergennachin marked this pull request as draft March 27, 2025 15:49
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Mar 27, 2025

@mergennachin has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

digantdesai
digantdesai reviewed Apr 8, 2025
View reviewed changes
test/build_size_test.sh Outdated

# TODO(#8357): Remove -Wno-int-in-bool-context
COMMON_CXXFLAGS="-fno-exceptions -fno-rtti -Wall -Werror -Wno-int-in-bool-context"
COMMON_CXXFLAGS="-fno-exceptions -fno-rtti -Wall -Werror -Wno-int-in-bool-context -Wno-stringop-overread"
Copy link
Contributor

@digantdesai digantdesai Apr 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah this, I thought I removed the memcpy which trigged this for Arm baremetal build.

digantdesai
digantdesai reviewed Apr 8, 2025
View reviewed changes
.github/workflows/pull.yml Outdated
threshold: 51784
- runner: linux.arm64.2xlarge
docker-image: executorch-ubuntu-22.04-gcc11-aarch64
threshold: 51784
Copy link
Contributor

@digantdesai digantdesai Apr 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have a big section ~32KiB IIRC for operator registration static arrays, we should not count that towards this. I have a WIP bare metal build where I can see ET text is ~11KiB, that is a good threshold to track IMHO. But this is a step in the right direction. Thanks.

@github-actions
Copy link

github-actions bot commented Aug 31, 2025

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

@github-actions github-actions bot added the stale PRs inactive for over 60 days label Aug 31, 2025
@github-actions
Copy link

github-actions bot commented Sep 17, 2025

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@github-actions
Copy link

github-actions bot commented Nov 18, 2025

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@digantdesai digantdesai digantdesai left review comments

@kirklandsign kirklandsign kirklandsign approved these changes

@lucylq lucylq Awaiting requested review from lucylq

@tarun292 tarun292 Awaiting requested review from tarun292

@JacobSzwejbka JacobSzwejbka Awaiting requested review from JacobSzwejbka

@larryliu0820 larryliu0820 Awaiting requested review from larryliu0820 larryliu0820 will be requested when the pull request is marked ready for review larryliu0820 is a code owner

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

+1 more reviewer

@swolchok swolchok swolchok approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. stale PRs inactive for over 60 days topic: not user facing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@mergennachin @swolchok @facebook-github-bot @digantdesai @kirklandsign