Skip to content

Conversation

@iliyan-georgiev-arm
Copy link
Collaborator

@iliyan-georgiev-arm iliyan-georgiev-arm commented Apr 9, 2025

  • Update process_placeholder and called functions to use _export.utils
  • Add test to validate non-persistent input buffers going forward
  • Remove workaround from test_llama

Change-Id: Ia1351ff7e54727fd9a84e1829695df22b350b7bd

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218

- Update process_placeholder and called functions to use _export.utils
- Add test to validate non-persistent input buffers going forward
- Remove workaround from test_llama

Signed-off-by: Iliyan Georgiev <[email protected]>
Change-Id: Ia1351ff7e54727fd9a84e1829695df22b350b7bd
@pytorch-bot
Copy link

pytorch-bot bot commented Apr 9, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9994

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 1 Pending

As of commit 872ee95 with merge base 91a14f1 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 9, 2025
@iliyan-georgiev-arm
Copy link
Collaborator Author

@pytorchbot label ciflow/trunk

@pytorch-bot
Copy link

pytorch-bot bot commented Apr 9, 2025

To add these label(s) (ciflow/trunk) to the PR, please first approve the workflows that are awaiting approval (scroll to the bottom of this page).

This helps ensure we don't trigger CI on this PR until it is actually authorized to do so. Please ping one of the reviewers if you do not have access to approve and run workflows.

@iliyan-georgiev-arm
Copy link
Collaborator Author

@pytorchbot label "topic: not user facing"

@iliyan-georgiev-arm
Copy link
Collaborator Author

@pytorchbot label "partner: arm"

@pytorch-bot pytorch-bot bot added the partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm label Apr 9, 2025
@pytorch-bot
Copy link

pytorch-bot bot commented Apr 10, 2025

To add the ciflow label ciflow/trunk please first approve the workflows that are awaiting approval (scroll to the bottom of this page).

This helps ensure we don't trigger CI on this PR until it is actually authorized to do so. Please ping one of the reviewers if you do not have access to approve and run workflows.

@zingo zingo merged commit bc03171 into pytorch:main Apr 11, 2025
168 of 169 checks passed
kirklandsign pushed a commit that referenced this pull request Apr 11, 2025
#9994)

- Update process_placeholder and called functions to use _export.utils
- Add test to validate non-persistent input buffers going forward
- Remove workaround from test_llama

Signed-off-by: Iliyan Georgiev <[email protected]>
keyprocedure pushed a commit to keyprocedure/executorch that referenced this pull request Apr 21, 2025
pytorch#9994)

- Update process_placeholder and called functions to use _export.utils
- Add test to validate non-persistent input buffers going forward
- Remove workaround from test_llama

Signed-off-by: Iliyan Georgiev <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm topic: not user facing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants