Skip to content
This repository was archived by the owner on Aug 21, 2025. It is now read-only.

Commit 0e08bf5

Browse files
committed
Fix CI
Added expected fails and fixed unexpected successes. Filed #913
1 parent 5710831 commit 0e08bf5

File tree

3 files changed

+8
-2
lines changed

3 files changed

+8
-2
lines changed

test/test_memory_efficient_fusion.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -239,6 +239,8 @@ def f(x):
239239
t = torch.randn(2, 2)
240240
check(f, t, 0)
241241

242+
# https://github.com/pytorch/functorch/issues/913
243+
@unittest.expectedFailure
242244
def test_rand_like(self):
243245
def f(x):
244246
a = torch.rand_like(x)
@@ -247,6 +249,8 @@ def f(x):
247249
t = torch.randn(2, 2)
248250
check(f, t, 0, check_val=False)
249251

252+
# https://github.com/pytorch/functorch/issues/913
253+
@unittest.expectedFailure
250254
def test_rand_n(self):
251255
def f(x):
252256
g_cpu = torch.Generator()

test/test_minifier.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,12 @@
22
from functorch.compile import minifier
33
from functorch import make_fx
44
from torch.testing._internal.common_utils import TestCase, run_tests
5+
import unittest
56

67

78
class TestMinifier(TestCase):
9+
# https://github.com/pytorch/functorch/issues/913
10+
@unittest.expectedFailure
811
def test_has_mul_minifier(self):
912
def failing_f(x, y):
1013
y = y / 3

test/test_ops.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -589,7 +589,6 @@ def vjp_of_vjp(*args_and_cotangents):
589589
xfail('__getitem__', ''), # dynamic error
590590
xfail('_masked.prod'), # calls aten::item
591591
xfail('eig'), # calls aten::item
592-
xfail('linalg.det', ''), # calls .item()
593592
xfail('linalg.eig'), # Uses aten::allclose
594593
xfail('linalg.householder_product'), # needs select_scatter
595594
xfail('linalg.slogdet'), # calls .item()
@@ -733,6 +732,7 @@ def test_vmapjvpall(self, device, dtype, op):
733732
xfail('lu'),
734733
xfail('cumprod'),
735734
xfail('lu_solve'),
735+
xfail('linalg.det'),
736736
xfail('linalg.lstsq', 'grad_oriented'),
737737
xfail('linalg.cholesky'),
738738
xfail('linalg.qr'),
@@ -1043,7 +1043,6 @@ def get_vjp(cotangents, *primals):
10431043
xfail('cdist', ''),
10441044
xfail('cholesky', ''),
10451045
xfail('eig', ''),
1046-
xfail('linalg.det', ''),
10471046
xfail('linalg.slogdet', ''),
10481047
xfail('logcumsumexp', ''),
10491048
xfail('logdet', ''),

0 commit comments

Comments
 (0)