Skip to content

Commit a8987d8

Browse files
author
samdow
committed
fix unexpected successes for binary cross entropy, linalg.norm, linalg.matrix_norm
1 parent e5eff20 commit a8987d8

File tree

1 file changed

+0
-9
lines changed

1 file changed

+0
-9
lines changed

test/test_ops.py

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -487,7 +487,6 @@ def _test(_op):
487487
skip('nn.functional.max_unpool2d'), # Flaky
488488
skip('nn.functional.fractional_max_pool2d'), # randomness
489489
skip('nn.functional.fractional_max_pool3d'), # randomness
490-
xfail('nn.functional.binary_cross_entropy'), # testing problem
491490
}))
492491
@opsToleranceOverride('TestOperators', 'test_vjpvjp', (
493492
tol1('nn.functional.conv_transpose3d',
@@ -597,9 +596,6 @@ def vjp_of_vjp(*args_and_cotangents):
597596
xfail('linalg.eig'), # Uses aten::allclose
598597
xfail('linalg.eigh'), # needs diag_scatter
599598
xfail('linalg.householder_product'), # needs select_scatter
600-
xfail('linalg.matrix_norm'),
601-
xfail('linalg.norm'),
602-
xfail('linalg.norm', 'subgradients_at_zero'),
603599
xfail('linalg.slogdet'), # calls .item()
604600
xfail('logdet'), # calls .item()
605601
xfail('matrix_exp'), # would benefit from narrow_scatter
@@ -759,9 +755,7 @@ def test_vmapjvp(self, device, dtype, op):
759755
xfail('nn.functional.hinge_embedding_loss', device_type='cpu'),
760756

761757
xfail('nn.functional.soft_margin_loss', ''),
762-
xfail('linalg.norm', 'subgradients_at_zero'),
763758
xfail('nn.functional.binary_cross_entropy_with_logits', ''),
764-
xfail('linalg.norm'),
765759
xfail('linalg.householder_product'),
766760
xfail('tensor_split'),
767761
xfail('quantile'),
@@ -875,7 +869,6 @@ def test_vmapjvpall(self, device, dtype, op):
875869
xfail('nn.functional.max_unpool2d', 'grad'),
876870
xfail('nn.functional.soft_margin_loss', ''),
877871
xfail('nn.functional.binary_cross_entropy_with_logits', ''),
878-
xfail('linalg.norm', 'subgradients_at_zero'),
879872
xfail('nn.functional.max_unpool1d', 'grad'),
880873
xfail('lu_unpack'),
881874
xfail('nn.functional.glu'),
@@ -934,8 +927,6 @@ def test():
934927
xfail('linalg.householder_product'),
935928
xfail('linalg.lstsq', ''),
936929
xfail('linalg.lstsq', 'grad_oriented'),
937-
xfail('linalg.matrix_norm'),
938-
xfail('linalg.norm'),
939930
xfail('linalg.pinv'),
940931
xfail('linalg.qr'),
941932
xfail('linalg.pinv', 'hermitian'),

0 commit comments

Comments
 (0)