Remove ErrorReporting class and simplify warning handling (#204)

Author: jansel

helion/_compiler/compile_environment.py

@@ -3,6 +3,7 @@
 import collections
 import contextlib
 import dataclasses
+import sys
 import threading
 import types
 import typing
@@ -19,7 +20,6 @@
 
 from .. import exc
 from ..language.constexpr import ConstExpr
-from .error_reporting import ErrorReporting
 from .loop_dependency_checker import LoopDependencyChecker
 from .variable_origin import BlockSizeOrigin
 from .variable_origin import Origin
@@ -55,7 +55,6 @@ def __init__(self, device: torch.device, settings: Settings) -> None:
         super().__init__()
         self.device = device
         self.settings = settings
-        self.errors = ErrorReporting(settings)
         self.shape_env = ShapeEnv(
             specialize_zero_one=True,
             duck_shape=False,
@@ -293,7 +292,6 @@ def __enter__(self) -> Self:
         assert getattr(tls, "env", None) is None, "CompileEnvironment already active"
         self.fake_mode.__enter__()
         tls.env = self
-        self.errors = ErrorReporting(self.settings)  # clear prior errors
         self.loop_dependency_checker = LoopDependencyChecker()
         return self
 
@@ -305,7 +303,6 @@ def __exit__(
     ) -> None:
         tls.env = None
         self.fake_mode.__exit__(exc_type, exc_value, traceback)
-        self.errors.raise_if_errors()
 
     @staticmethod
     def current() -> CompileEnvironment:
@@ -482,7 +479,17 @@ def from_config(self, config: Config, block_id: int) -> int | None:
 
 
 def warning(warning: exc.BaseWarning | type[exc.BaseWarning]) -> None:
-    CompileEnvironment.current().errors.add(warning)
+    """Print a warning to stderr if it's not in the ignore list."""
+    env = CompileEnvironment.current()
+    if callable(warning):
+        warning = warning()
+
+    if not isinstance(warning, exc.BaseWarning):
+        raise TypeError(f"expected BaseWarning, got {type(warning)}")
+
+    # Check if this warning type should be ignored
+    if not isinstance(warning, tuple(env.settings.ignore_warnings)):
+        print(f"WARNING[{type(warning).__name__}]: {warning.args[0]}", file=sys.stderr)
 
 
 def _to_sympy(x: int | torch.SymInt) -> sympy.Expr:

helion/_compiler/device_ir.py

@@ -883,7 +883,6 @@ def lower_to_device_ir(func: HostFunction) -> DeviceIR:
         visitor = WalkHostAST(device_ir)
         for stmt in func.body:
             visitor.visit(stmt)
-        CompileEnvironment.current().errors.raise_if_errors()
         for graph in device_ir.graphs:
             prepare_graph_lowerings(graph.graph)
         for graph in device_ir.graphs:

helion/_compiler/error_reporting.py

@@ -399,7 +399,6 @@ def generate_ast(func: HostFunction, config: Config) -> ast.AST:
         with codegen.device_function:
             for stmt in func.body:
                 codegen.add_statement(codegen.visit(stmt))
-            CompileEnvironment.current().errors.raise_if_errors()
             kernel_def = codegen.device_function.codegen_function_def()
             host_def = func.codegen_function_def(codegen.host_statements)
             precompile_def = codegen_precompile_def(

helion/_compiler/generate_ast.py

@@ -103,7 +103,6 @@ def __init__(
             from .type_propagation import propagate_types
 
             propagate_types(self, fake_args)
-            env.errors.raise_if_errors()
             env.finalize_config_spec()
             self.device_ir = lower_to_device_ir(self)
 
@@ -208,8 +207,6 @@ def debug_str(self) -> str:
             ),
             self.device_ir.debug_str(),
         ]
-        if error_str := CompileEnvironment.current().errors.report(strip_paths=True):
-            result.extend(error_str)
         return "\n\n".join(result)
 
     def codegen_function_def(self, statements: list[ast.AST]) -> ast.FunctionDef: