Skip to content

Conversation

joydddd
Copy link
Contributor

@joydddd joydddd commented Jun 16, 2025

joydddd added a commit that referenced this pull request Jun 16, 2025
stack-info: PR: #188, branch: joydddd/stack/4
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Jun 16, 2025
@joydddd joydddd changed the base branch from joydddd/stack/3 to main June 16, 2025 23:18
joydddd added a commit that referenced this pull request Jun 16, 2025
stack-info: PR: #188, branch: joydddd/stack/4
@joydddd joydddd changed the base branch from main to joydddd/stack/3 June 16, 2025 23:18
@joydddd joydddd marked this pull request as ready for review June 16, 2025 23:21
@joydddd
Copy link
Contributor Author

joydddd commented Jun 16, 2025

Unit test test_indexing.test_tile_id_2d_indexing skipped due to bug: #185 Please enable after the bug is fixed~

@joydddd joydddd changed the base branch from joydddd/stack/3 to main June 16, 2025 23:31
joydddd added a commit that referenced this pull request Jun 16, 2025
stack-info: PR: #188, branch: joydddd/stack/4
@joydddd joydddd changed the base branch from main to joydddd/stack/3 June 16, 2025 23:31
@joydddd joydddd changed the base branch from joydddd/stack/3 to main June 16, 2025 23:37
joydddd added a commit that referenced this pull request Jun 16, 2025
stack-info: PR: #188, branch: joydddd/stack/4
@joydddd joydddd changed the base branch from main to joydddd/stack/3 June 16, 2025 23:37
@joydddd joydddd requested review from jansel, yf225 and drisspg June 16, 2025 23:37
joydddd added a commit that referenced this pull request Jun 16, 2025
stack-info: PR: #188, branch: joydddd/stack/4
@joydddd joydddd changed the base branch from joydddd/stack/3 to main June 16, 2025 23:42
stack-info: PR: #188, branch: joydddd/stack/4
Copy link
Contributor

@drisspg drisspg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@joydddd joydddd merged commit feb86dc into main Jun 17, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants