Skip to content

Commit b828059

Browse files
authored
Removed mkl from dev deps (#3226)
* Removed mkl from dev deps * Updated tpu gha yaml * Install mkl for tpu GHA * fix mkl installation for tpu GHA * fix tpu gha * fix tpu gha 2
1 parent 216b348 commit b828059

File tree

2 files changed

+14
-9
lines changed

2 files changed

+14
-9
lines changed

.github/workflows/tpu-tests.yml

Lines changed: 14 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -8,12 +8,16 @@ on:
88
- "ignite/**"
99
- "tests/ignite/**"
1010
- "tests/run_tpu_tests.sh"
11+
- "tests/run_code_style.sh"
12+
- "requirements-dev.txt"
1113
- ".github/workflows/tpu-tests.yml"
1214
pull_request:
1315
paths:
1416
- "ignite/**"
1517
- "tests/ignite/**"
1618
- "tests/run_tpu_tests.sh"
19+
- "tests/run_code_style.sh"
20+
- "requirements-dev.txt"
1721
- ".github/workflows/tpu-tests.yml"
1822
workflow_dispatch:
1923

@@ -32,10 +36,10 @@ jobs:
3236

3337
steps:
3438
- uses: actions/checkout@v4
35-
- name: Set up Python 3.8
39+
- name: Set up Python 3.9
3640
uses: actions/setup-python@v4
3741
with:
38-
python-version: "3.8"
42+
python-version: "3.9"
3943
architecture: "x64"
4044

4145
- name: Get year & week number
@@ -61,15 +65,17 @@ jobs:
6165
- name: Install Torch XLA and others
6266
run: |
6367
64-
## Install openblas, mkl, gsutil
68+
## Install mkl (alternative approach to https://github.com/pytorch/xla/blob/b0ba29f98a695671972d4a4cc07441014dba2892/.kokoro/common.sh#L31-L32)
6569
sudo apt-get update && sudo apt-get install -y libopenblas-dev libomp5
66-
# mkl version fixed due to https://github.com/pytorch/ignite/issues/2350
67-
pip install mkl==2021.4.0 requests gsutil
70+
pip install mkl==2021.4.0
6871
6972
## Install torch & xla and torchvision
70-
pip install --pre https://storage.googleapis.com/tpu-pytorch/wheels/colab/torch-nightly-cp38-cp38-linux_x86_64.whl
71-
pip install --pre https://storage.googleapis.com/tpu-pytorch/wheels/colab/torch_xla-nightly-cp38-cp38-linux_x86_64.whl
72-
pip install --pre https://storage.googleapis.com/tpu-pytorch/wheels/colab/torchvision-nightly-cp38-cp38-linux_x86_64.whl
73+
pip install --pre https://storage.googleapis.com/tpu-pytorch/wheels/colab/torch-nightly-cp39-cp39-linux_x86_64.whl
74+
pip install --pre https://storage.googleapis.com/tpu-pytorch/wheels/colab/torch_xla-nightly-cp39-cp39-linux_x86_64.whl
75+
pip install --pre https://storage.googleapis.com/tpu-pytorch/wheels/colab/torchvision-nightly-cp39-cp39-linux_x86_64.whl
76+
77+
# Check installation
78+
python -c "import torch"
7379
7480
## Install test deps and Ignite
7581
pip install -r requirements-dev.txt

requirements-dev.txt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,5 @@ git+https://github.com/nltk/nltk
2929
# Examples dependencies
3030
pandas
3131
gymnasium
32-
mkl;platform_machine=="x86_64"
3332
# temporary fix: E AttributeError: module 'mpmath' has no attribute 'rational'
3433
mpmath<1.4

0 commit comments

Comments
 (0)