PyTorch Profiler [WIP] #2906
Draft
PyTorch Profiler [WIP] #2906
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into pt_profiler
…into pt_profiler
|
Hey @vfdev-5 @sdesrozis I have added a check for minimum PyTorch version, Now I wanted to ask whether we should keep this profiler in the main module or in the contrib module as most of the handlers introduced afterwards were put there. Also what should be the additional tests that should be present in this handler? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1917
(uses #2315)
Description: Added check for minimum version of PyTorch for import. Now need to add tests for the Profiler
Check list: