[BugFix] Avoid overlapping temporary dirs during training (#1635)

Author: Vincent Moens

examples/cql/utils.py

@@ -90,7 +90,7 @@ def make_replay_buffer(
     batch_size,
     prb=False,
     buffer_size=1000000,
-    buffer_scratch_dir="/tmp/",
+    buffer_scratch_dir=None,
     device="cpu",
     prefetch=3,
 ):

examples/ddpg/ddpg.py

@@ -69,7 +69,7 @@ def main(cfg: "DictConfig"):  # noqa: F821
         batch_size=cfg.optim.batch_size,
         prb=cfg.replay_buffer.prb,
         buffer_size=cfg.replay_buffer.size,
-        buffer_scratch_dir="/tmp/" + cfg.replay_buffer.scratch_dir,
+        buffer_scratch_dir=cfg.replay_buffer.scratch_dir,
         device=device,
     )
 

examples/ddpg/utils.py

@@ -107,7 +107,7 @@ def make_replay_buffer(
     batch_size,
     prb=False,
     buffer_size=1000000,
-    buffer_scratch_dir="/tmp/",
+    buffer_scratch_dir=None,
     device="cpu",
     prefetch=3,
 ):

examples/decision_transformer/dt_config.yaml

@@ -34,7 +34,7 @@ replay_buffer:
   stacked_frames: 20
   buffer_prefetch: 64
   capacity: 1_000_000
-  buffer_scratch_dir: "/tmp/"
+  buffer_scratch_dir:
   device: cpu
   prefetch: 3
 

examples/decision_transformer/odt_config.yaml

@@ -34,7 +34,7 @@ replay_buffer:
   stacked_frames: 20
   buffer_prefetch: 64
   capacity: 1_000_000
-  buffer_scratch_dir: "/tmp/"
+  buffer_scratch_dir:
   device: cuda:0
   prefetch: 3
 

examples/decision_transformer/utils.py

@@ -287,7 +287,9 @@ def make_online_replay_buffer(offline_buffer, rb_cfg, reward_scaling=0.001):
         catframes,
     )
     storage = LazyMemmapStorage(
-        rb_cfg.capacity, rb_cfg.buffer_scratch_dir, device=rb_cfg.device
+        max_size=rb_cfg.capacity,
+        scratch_dir=rb_cfg.buffer_scratch_dir,
+        device=rb_cfg.device,
     )
 
     replay_buffer = TensorDictReplayBuffer(

examples/discrete_sac/discrete_sac.py

@@ -43,7 +43,7 @@ def make_replay_buffer(
     prb=False,
     buffer_size=1000000,
     batch_size=256,
-    buffer_scratch_dir="/tmp/",
+    buffer_scratch_dir=None,
     device="cpu",
     prefetch=3,
 ):

examples/iql/iql_online.py

@@ -39,7 +39,7 @@ def make_replay_buffer(
     batch_size,
     prb=False,
     buffer_size=1000000,
-    buffer_scratch_dir="/tmp/",
+    buffer_scratch_dir=None,
     device="cpu",
     prefetch=3,
 ):

examples/sac/sac.py

@@ -69,7 +69,7 @@ def main(cfg: "DictConfig"):  # noqa: F821
         batch_size=cfg.optim.batch_size,
         prb=cfg.replay_buffer.prb,
         buffer_size=cfg.replay_buffer.size,
-        buffer_scratch_dir="/tmp/" + cfg.replay_buffer.scratch_dir,
+        buffer_scratch_dir=cfg.replay_buffer.scratch_dir,
         device=device,
     )
 

examples/sac/utils.py

@@ -89,7 +89,7 @@ def make_replay_buffer(
     batch_size,
     prb=False,
     buffer_size=1000000,
-    buffer_scratch_dir="/tmp/",
+    buffer_scratch_dir=None,
     device="cpu",
     prefetch=3,
 ):