[CI] Fix linter (#3121)

Author: vmoens

.github/unittest/helpers/coverage_run_parallel.py

@@ -17,10 +17,9 @@
 import sys
 import tempfile
 from pathlib import Path
-from typing import List
 
 
-def write_config(config_path: Path, argv: List[str]) -> None:
+def write_config(config_path: Path, argv: list[str]) -> None:
     """
     Write a coverage.py config that is equivalent to the command line arguments passed here.
     Args:
@@ -42,7 +41,7 @@ def write_config(config_path: Path, argv: List[str]) -> None:
         )
 
 
-def main(argv: List[str]) -> int:
+def main(argv: list[str]) -> int:
     if len(argv) < 1:
         print(  # noqa
             "Usage: 'python coverage_run_parallel.py <command> [command arguments]'"

.github/workflows/lint.yml

@@ -30,7 +30,7 @@ jobs:
         echo '::group::Setup environment'
         CONDA_PATH=$(which conda)
         eval "$(${CONDA_PATH} shell.bash hook)"
-        conda create --name ci --quiet --yes python=3.8 pip
+        conda create --name ci --quiet --yes python=3.11 pip
         conda activate ci
         echo '::endgroup::'
         
@@ -58,7 +58,7 @@ jobs:
         echo '::group::Setup environment'
         CONDA_PATH=$(which conda)
         eval "$(${CONDA_PATH} shell.bash hook)"
-        conda create --name ci --quiet --yes -c conda-forge python=3.8 ncurses=5 libgcc
+        conda create --name ci --quiet --yes -c conda-forge python=3.11 ncurses=5 libgcc
         conda activate ci
         export LD_LIBRARY_PATH="${CONDA_PREFIX}/lib:${LD_LIBRARY_PATH}"
         echo '::endgroup::'

.pre-commit-config.yaml

@@ -17,18 +17,17 @@ repos:
         additional_dependencies:
           - black == 22.3.0
           - usort == 1.0.3
-          - libcst == 0.4.7
+          - libcst == 1.0.1
 
   - repo: https://github.com/pycqa/flake8
-    rev: 7.3.0
+    rev: 6.1.0
     hooks:
       - id: flake8
         args: [--config=setup.cfg]
         additional_dependencies:
           - flake8-bugbear==22.10.27
           - flake8-comprehensions==3.10.1
-          - torchfix==0.0.2
-          - flake8-print==5.0.0
+          - flake8-print==4.0.1
 
   - repo: https://github.com/PyCQA/pydocstyle
     rev: 6.3.0
@@ -40,7 +39,7 @@ repos:
     rev: v3.20.0
     hooks:
       - id: pyupgrade
-        args: [--py38-plus]
+        args: [--py311-plus]
 
   - repo: local
     hooks:

benchmarks/ecosystem/vmas_rllib_vs_torchrl_sampling_performance.py

@@ -9,7 +9,6 @@
 
 import time
 from pathlib import Path
-from typing import Dict
 
 import numpy as np
 
@@ -93,7 +92,7 @@ def on_train_result(
                 - result["timers"]["learn_time_ms"]
             )
 
-    def env_creator(config: Dict):
+    def env_creator(config: dict):
         env = vmas.make_env(
             scenario=config["scenario_name"],
             num_envs=config["num_envs"],

docs/source/content_generation.py

@@ -1,7 +1,6 @@
 import os
 import shutil
 from pathlib import Path
-from typing import List
 
 FILE_DIR = os.path.dirname(__file__)
 KNOWLEDGE_GEN_DIR = "reference/generated/knowledge_base"
@@ -10,7 +9,7 @@
 TUTORIALS_MEDIA_GEN_DIR = "reference/generated/tutorials/media"
 
 
-def _get_file_content(name: str) -> List[str]:
+def _get_file_content(name: str) -> list[str]:
     """A function to get the content of a reference file.
 
     Given the name of a knowledge base file, populates a file template. The result can be used to link a knowledge base

setup.cfg

@@ -24,12 +24,16 @@ per-file-ignores =
     torchrl/objectives/sac.py: TOR101
     torchrl/objectives/td3.py: TOR101
     torchrl/objectives/value/advantages.py: TOR101
-    tutorials/*/**.py: T201
-    examples/*.py: T201
-    packaging/verify_nightly_version.py: T201
-    test/opengl_rendering.py: T201
-    */**/run-clang-format.py: T201
-    packaging/*/**.py: T201
+    tutorials/*/**.py: T001, T201
+    examples/*.py: T001, T201
+    packaging/verify_nightly_version.py: T001, T201
+    test/opengl_rendering.py: T001, T201
+    */**/run-clang-format.py: T001, T201
+    packaging/*/**.py: T001, T201
+    .github/unittest/linux_sota/scripts/test_sota.py: T001
+    docs/source/conf.py: T001
+    test/test_libs.py: T001
+    torchrl/_utils.py: T002
 
 exclude = venv
 extend-select = B901, C401, C408, C409, TOR0, TOR1, TOR2

sota-implementations/grpo/grpo_utils.py

@@ -5,7 +5,8 @@
 from __future__ import annotations
 
 import time
-from typing import Any, Callable, Literal
+from collections.abc import Callable
+from typing import Any, Literal
 
 import torch
 from omegaconf import DictConfig

sota-implementations/redq/utils.py

@@ -4,8 +4,9 @@
 # LICENSE file in the root directory of this source tree.
 from __future__ import annotations
 
+from collections.abc import Callable, Sequence
+
 from copy import copy
-from typing import Callable, Sequence
 
 import torch
 from omegaconf import OmegaConf

test/_utils_internal.py

@@ -11,8 +11,8 @@
 import sys
 import time
 import unittest
+from collections.abc import Callable
 from functools import wraps
-from typing import Callable
 
 import pytest
 import torch

test/llm/test_data.py

@@ -7,7 +7,7 @@
 
 import argparse
 import importlib.util
-from typing import Mapping
+from collections.abc import Mapping
 
 import pytest
 import torch