Update

[ghstack-poisoned]

Author: vmoens

.github/unittest/linux_olddeps/scripts_gym_0_13/environment.yml

@@ -28,4 +28,3 @@ dependencies:
     - av
     - h5py
     - numpy<2.0.0
-    - pybind11[global]

setup.py

@@ -18,27 +18,6 @@
 logger = logging.getLogger(__name__)
 
 ROOT_DIR = Path(__file__).parent.resolve()
-
-
-def _check_pybind11():
-    """Check that pybind11 is installed and provide a clear error message if not.
-
-    Only checks when actually building extensions, not for commands like 'clean'.
-    """
-    # Commands that don't require building C++ extensions
-    skip_commands = {"clean", "egg_info", "sdist", "--version", "--help", "-h"}
-    if skip_commands.intersection(sys.argv):
-        return
-    if importlib.util.find_spec("pybind11") is None:
-        raise RuntimeError(
-            "pybind11 is required to build TorchRL's C++ extensions but was not found.\n"
-            "Please install it with:\n"
-            "    pip install 'pybind11[global]'\n"
-            "Then re-run the installation."
-        )
-
-
-_check_pybind11()
 _RELEASE_BRANCH_RE = re.compile(r"^release/v(?P<release_id>.+)$")
 _BUILD_INFO_FILE = ROOT_DIR / "build" / ".torchrl_build_info.json"
 
@@ -68,14 +47,13 @@ def _check_and_clean_stale_builds():
                     f"Python {old_python} -> {current_python_version}. "
                     f"Cleaning stale build artifacts..."
                 )
-                # Clean stale extension files for current Python version
-                ext = ".pyd" if sys.platform == "win32" else ".so"
-                ext_pattern = (
+                # Clean stale .so files for current Python version
+                so_pattern = (
                     ROOT_DIR
                     / "torchrl"
-                    / f"_torchrl.cpython-{sys.version_info.major}{sys.version_info.minor}*{ext}"
+                    / f"_torchrl.cpython-{sys.version_info.major}{sys.version_info.minor}*.so"
                 )
-                for so_file in glob.glob(str(ext_pattern)):
+                for so_file in glob.glob(str(so_pattern)):
                     logger.warning(f"Removing stale: {so_file}")
                     os.remove(so_file)
                 # Clean build directory