Skip to content

Commit cdcd9f3

Browse files
author
Vincent Moens
authored
[BugFix] done = done | truncated in collector (#2333)
1 parent 0063741 commit cdcd9f3

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

torchrl/collectors/collectors.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1121,7 +1121,10 @@ def _maybe_set_truncated(self, final_rollout):
11211121
truncated = final_rollout["next", truncated_key]
11221122
truncated[last_step] = True
11231123
final_rollout["next", truncated_key] = truncated
1124-
final_rollout["next", _replace_last(truncated_key, "done")] = truncated
1124+
done = final_rollout["next", _replace_last(truncated_key, "done")]
1125+
final_rollout["next", _replace_last(truncated_key, "done")] = (
1126+
done | truncated
1127+
)
11251128
return final_rollout
11261129

11271130
@torch.no_grad()

0 commit comments

Comments
 (0)