Skip to content

Commit 0192d56

Browse files
authored
Silent the annotation error when getting docker_hub_readonly_token secret (#7054)
This annoyance is showing up on all pet instances benchmark jobs, for example https://github.com/pytorch/pytorch/actions/runs/17201748116. As the failure is ignored anyway, let's just pipe that to `true` to silent it. ### Testing pytorch/pytorch#161496 Signed-off-by: Huy Do <[email protected]>
1 parent 4b35d89 commit 0192d56

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

.github/actions/calculate-docker-image/action.yml

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -195,11 +195,10 @@ runs:
195195
196196
- name: Login to Docker Hub
197197
shell: bash
198-
# It's ok if this steps fails, it would then be an anonymous user like what we used to have
199-
continue-on-error: true
200198
run: |
201199
set -eux
202-
aws secretsmanager get-secret-value --secret-id docker_hub_readonly_token | jq --raw-output '.SecretString' | jq -r .docker_hub_readonly_token | docker login --username pytorchbot --password-stdin
200+
# It's ok if this steps fails, it would then be an anonymous user like what we used to have
201+
aws secretsmanager get-secret-value --secret-id docker_hub_readonly_token | jq --raw-output '.SecretString' | jq -r .docker_hub_readonly_token | docker login --username pytorchbot --password-stdin || true
203202
204203
- name: Build docker image
205204
if: ${{ steps.calculate-image.outputs.skip != 'true' && (inputs.always-rebuild || steps.check-image.outputs.rebuild) }}

0 commit comments

Comments
 (0)