Skip to content

Commit 2128997

Browse files
authored
Upgrade github ubuntu-20.04 runners to ubuntu-24.04 (#6357)
See pytorch/pytorch#148469 for context Also fix failing test, maybe package update changed the error string?
1 parent 7943851 commit 2128997

File tree

7 files changed

+8
-7
lines changed

7 files changed

+8
-7
lines changed

.github/actionlint.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
self-hosted-runner:
22
labels:
3+
- ubuntu-24.04 # GitHub hosted runner that actionlint doesn't recognize because actionlint version (1.6.21) is too old
34
- macos-13
45
- macos-m1-stable
56
- linux.12xlarge

.github/workflows/backfill-workflow-job.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ defaults:
1414
working-directory: torchci
1515
jobs:
1616
backfill-workflow-job:
17-
runs-on: ubuntu-20.04
17+
runs-on: ubuntu-24.04
1818
steps:
1919
- name: configure aws credentials
2020
uses: aws-actions/[email protected]

.github/workflows/log-classifier-lambda.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,14 +17,14 @@ defaults:
1717

1818
jobs:
1919
test:
20-
runs-on: ubuntu-20.04
20+
runs-on: ubuntu-24.04
2121
steps:
2222
- uses: actions/checkout@v4
2323
- run: cargo test
2424

2525
deploy:
2626
needs: test
27-
runs-on: ubuntu-20.04
27+
runs-on: ubuntu-24.04
2828
if: ${{ github.event_name == 'push' && github.ref == 'refs/heads/main' }}
2929
permissions:
3030
id-token: write

.github/workflows/revert-tracker.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ on:
88

99
jobs:
1010
revert_printer:
11-
runs-on: ubuntu-20.04
11+
runs-on: ubuntu-24.04
1212
permissions:
1313
contents: write
1414
steps:

.github/workflows/torchci.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ on:
1111

1212
jobs:
1313
test:
14-
runs-on: ubuntu-20.04
14+
runs-on: ubuntu-24.04
1515
defaults:
1616
run:
1717
working-directory: torchci

.github/workflows/update-queue-times.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ defaults:
1111
working-directory: torchci
1212
jobs:
1313
update-queue-times:
14-
runs-on: ubuntu-20.04
14+
runs-on: ubuntu-24.04
1515
permissions:
1616
id-token: write
1717
steps:

torchci/lib/utilization/fetchUtilization.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -213,7 +213,7 @@ describe("Test flattenTS to flatten timestamp", () => {
213213

214214
// assert log
215215
expect(logSpy).toHaveBeenCalledWith(
216-
`Warning: Error parsing JSON:SyntaxError: Unexpected token { in JSON at position 1 for data string '${invalidData}'`
216+
`Warning: Error parsing JSON:SyntaxError: Expected property name or '}' in JSON at position 1 for data string '{{}dsad}'`
217217
);
218218
});
219219
});

0 commit comments

Comments
 (0)