Skip to content

Commit 3380b47

Browse files
authored
Move all viable/strict blocking jobs closer to the beginning (#6947)
Some pull and trunk jobs had newer naming conventions, so they were getting dumped in the "other" category on HUD where failures are harder to notice. Creating a new "other" category just for viable/strict blocking jobs in a place where the eye is more easily to notice the failure Adds a new "Other viable/strict blocking" category for jobs on the HUD home page New group and the jobs it contains: <img width="1552" height="627" alt="image" src="https://github.com/user-attachments/assets/f98c254a-f632-46db-9ca3-6c4f292ef529" />
1 parent c316dbc commit 3380b47

File tree

1 file changed

+10
-1
lines changed

1 file changed

+10
-1
lines changed

torchci/lib/JobClassifierUtil.ts

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@ const GROUP_MAC = "Mac";
2727
const GROUP_PARALLEL = "Parallel";
2828
const GROUP_DOCS = "Docs";
2929
const GROUP_LIBTORCH = "Libtorch";
30+
const GROUP_OTHER_VIABLE_STRICT_BLOCKING = "Other viable/strict blocking";
3031
const GROUP_OTHER = "other";
3132

3233
// Jobs will be grouped with the first regex they match in this list
@@ -138,6 +139,12 @@ export const groups = [
138139
regex: /libtorch/,
139140
name: GROUP_LIBTORCH,
140141
},
142+
{
143+
// This is a catch-all for jobs that are viable but strict blocking
144+
// Excluding linux-binary-* jobs because they are already grouped further up
145+
regex: /(pull)|(trunk)/,
146+
name: GROUP_OTHER_VIABLE_STRICT_BLOCKING,
147+
},
141148
];
142149

143150
// Jobs on HUD home page will be sorted according to this list, with anything left off at the end
@@ -150,6 +157,7 @@ const HUD_GROUP_SORTING = [
150157
GROUP_MAC,
151158
GROUP_ROCM,
152159
GROUP_XLA,
160+
GROUP_OTHER_VIABLE_STRICT_BLOCKING, // placed after the last group that tends to have viable/strict blocking jobs
153161
GROUP_PARALLEL,
154162
GROUP_LIBTORCH,
155163
GROUP_ANDROID,
@@ -164,10 +172,11 @@ const HUD_GROUP_SORTING = [
164172
GROUP_INDUCTOR,
165173
GROUP_INDUCTOR_PERIODIC,
166174
GROUP_ANNOTATIONS_AND_LABELING,
167-
GROUP_OTHER,
168175
GROUP_BINARY_WINDOWS,
169176
GROUP_MEMORY_LEAK_CHECK,
170177
GROUP_RERUN_DISABLED_TESTS,
178+
// These two groups should always be at the end
179+
GROUP_OTHER,
171180
GROUP_UNSTABLE,
172181
];
173182

0 commit comments

Comments
 (0)