Skip to content

Commit 3836ad9

Browse files
authored
fix makefile lint & typo (#7166)
1 parent 2a52d66 commit 3836ad9

File tree

4 files changed

+15
-17
lines changed

4 files changed

+15
-17
lines changed
Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,20 +1,20 @@
11
all: run-local
22

33
clean:
4-
rm -rf deployment
5-
rm -rf venv
6-
rm -rf deployment.zip
4+
rm -rf deployment
5+
rm -rf venv
6+
rm -rf deployment.zip
77

88
venv/bin/python:
9-
virtualenv venv
10-
venv/bin/pip install -r requirements.txt
9+
virtualenv venv
10+
venv/bin/pip install -r requirements.txt
1111

1212
deployment.zip:
13-
mkdir -p deployment
14-
cp lambda_function.py ./deployment/.
13+
mkdir -p deployment
14+
cp lambda_function.py ./deployment/.
1515
cp -r common ./deployment/common
16-
pip3.10 install -r requirements.txt -t ./deployment/. --platform manylinux2014_x86_64 --only-binary=:all: --implementation cp --python-version 3.10 --upgrade
17-
cd ./deployment && zip -q -r ../deployment.zip .
16+
pip3.10 install -r requirements.txt -t ./deployment/. --platform manylinux2014_x86_64 --only-binary=:all: --implementation cp --python-version 3.10 --upgrade
17+
cd ./deployment && zip -q -r ../deployment.zip .
1818

1919
.PHONY: create-deployment-package
2020
create-deployment-package: deployment.zip

aws/lambda/benchmark_regression_summary_report/lambda_function.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -49,9 +49,7 @@ def get_clickhouse_client(
4949
host: str, user: str, password: str
5050
) -> clickhouse_connect.driver.client.Client:
5151
# for local testing only, disable SSL verification
52-
return clickhouse_connect.get_client(
53-
host=host, user=user, password=password, secure=True, verify=False
54-
)
52+
# return clickhouse_connect.get_client(host=host, user=user, password=password, secure=True, verify=False)
5553
return clickhouse_connect.get_client(
5654
host=host, user=user, password=password, secure=True
5755
)

clickhouse_db_schema/benchmark_regression_report/schema.sql

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
CREATE TABLE fortesting.benchmark_regression_report
1+
CREATE TABLE benchmark.benchmark_regression_report
22
(
33
`id` UUID DEFAULT generateUUIDv4(),
44
`report_id` String,

torchci/lib/benchmark/api_helper/utils.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -26,11 +26,11 @@ type Subgroup<T> = {
2626
*/
2727
type GroupedItem<T> = {
2828
/** Metadata fields for this group (e.g., dtype, arch, compiler). */
29-
group_Info: GroupInfo;
29+
group_info: GroupInfo;
3030

3131
/**
3232
* Rows keyed by a unique identifier string,
33-
* derived from a distinct combination of subgroup `group_Info` fields.
33+
* derived from a distinct combination of subgroup `group_info` fields.
3434
* Each entry corresponds to one subgroup that contains data points.
3535
*/
3636
rows: Record<string, Subgroup<T>>;
@@ -124,7 +124,7 @@ export function groupByBenchmarkData<T>(
124124
for (const [mainKey, subMap] of groups.entries()) {
125125
const rowsObj = Object.fromEntries(subMap.entries());
126126
result.push({
127-
group_Info: mainInfo.get(mainKey)!,
127+
group_info: mainInfo.get(mainKey)!,
128128
rows: rowsObj,
129129
});
130130
}
@@ -249,7 +249,7 @@ export function to_time_series_data(
249249
let diffs: any[] = [];
250250

251251
const result = tsd.map((group) => {
252-
const group_info = group.group_Info;
252+
const group_info = group.group_info;
253253
const sub_group_data = group.rows;
254254
// extract the first data point for each sub group
255255
// since we only have one datapoint for each unique workflow id with the same group info

0 commit comments

Comments
 (0)