[HUD] add filter for non-viable strict jobs (#7349)

1. adds a filter to hide non-viable strict jobs:
<img width="240" height="34" alt="image"
src="https://github.com/user-attachments/assets/8e8a6eef-bc7c-492b-9de2-c28412b439a8"
/>


2. in grouped view makes the border more obvious / adds tooltip info:
<img width="826" height="173" alt="image"
src="https://github.com/user-attachments/assets/c5e9d07a-1651-4f0d-86f5-4430b5a6c3f8"
/>
<img width="303" height="108" alt="image"
src="https://github.com/user-attachments/assets/c4b8ba14-461e-42d2-a970-3489c7e2cc5d"
/>


3. syncs the viable-strict logic with [the
source](https://github.com/pytorch/pytorch/blob/main/.github/workflows/update-viablestrict.yml#L26)
(per the comment in the original implementation)
Note: we really need to centralize the config for viable/strict, but
that's out of the scope of this PR.

Author: izaitsevfb

torchci/components/job/GroupJobConclusion.tsx

@@ -3,7 +3,10 @@ import {
   isGroupAutorevertSignal,
   isJobAutorevertSignal,
 } from "lib/autorevertUtils";
-import { getGroupConclusionChar } from "lib/JobClassifierUtil";
+import {
+  getGroupConclusionChar,
+  isJobViableStrictBlocking,
+} from "lib/JobClassifierUtil";
 import {
   isCancellationSuccessJob,
   isFailedJob,
@@ -43,44 +46,6 @@ export enum GroupedJobStatus {
   Pending = "pending",
 }
 
-type RepoViableStrictBlockingJobsMap = {
-  [key: string]: RegExp[];
-};
-
-// TODO: Move this to a config file
-const VIABLE_STRICT_BLOCKING_JOBS: RepoViableStrictBlockingJobsMap = {
-  // Source of truth for these jobs is in https://github.com/pytorch/pytorch/blob/main/.github/workflows/update-viablestrict.yml#L26
-  "pytorch/pytorch": [
-    /trunk/i,
-    /pull/i,
-    /lint/i,
-    /linux-binary-libtorch-release /i,
-    /linux-binary-manywheel /i,
-    /linux-aarch64/i,
-  ],
-};
-
-function isJobViableStrictBlocking(
-  jobName: string | undefined,
-  repoOwner: string,
-  repoName: string
-): boolean {
-  if (!jobName) {
-    return false;
-  }
-
-  const repo = `${repoOwner}/${repoName}`;
-  let viablestrict_blocking_jobs_patterns =
-    VIABLE_STRICT_BLOCKING_JOBS[repo] ?? [];
-
-  for (const regex of viablestrict_blocking_jobs_patterns) {
-    if (jobName.match(regex)) {
-      return true;
-    }
-  }
-  return false;
-}
-
 // React component to render either a group conclusion character or monsterized icons for failures
 function GroupConclusionContent({
   conclusion,
@@ -276,6 +241,8 @@ export default function HudGroupedCell({
               failedPreviousRunJobs={failedPreviousRunJobs}
               sha={sha}
               rowData={rowData}
+              repoOwner={repoOwner}
+              repoName={repoName}
             />
           }
         >
@@ -326,6 +293,8 @@ function GroupTooltip({
   failedPreviousRunJobs,
   sha,
   rowData,
+  repoOwner,
+  repoName,
 }: {
   conclusion: GroupedJobStatus;
   groupName: string;
@@ -335,6 +304,8 @@ function GroupTooltip({
   failedPreviousRunJobs: JobData[];
   sha?: string;
   rowData?: RowData;
+  repoOwner?: string;
+  repoName?: string;
 }) {
   const [monsterFailures] = useContext(MonsterFailuresContext);
 
@@ -382,6 +353,10 @@ function GroupTooltip({
                 const isAutorevert = rowData
                   ? isJobAutorevertSignal(job, rowData)
                   : false;
+                const isViableStrictBlocking =
+                  repoOwner &&
+                  repoName &&
+                  isJobViableStrictBlocking(job.name, repoOwner, repoName);
                 return (
                   <div
                     key={jobIndex}
@@ -400,6 +375,12 @@ function GroupTooltip({
                       {job.name}
                       {isAutorevert && " ⚠️ (triggered autorevert)"}
                     </a>
+                    {isViableStrictBlocking && (
+                      <span style={{ color: "orange", fontWeight: "bold" }}>
+                        {" "}
+                        [viable/strict blocking]
+                      </span>
+                    )}
                   </div>
                 );
               })}
@@ -416,6 +397,8 @@ function GroupTooltip({
         jobs={erroredJobs}
         message={"The following jobs errored out:"}
         rowData={rowData}
+        repoOwner={repoOwner}
+        repoName={repoName}
       />
     );
   } else if (conclusion === GroupedJobStatus.Queued) {
@@ -426,6 +409,8 @@ function GroupTooltip({
         jobs={queuedJobs}
         message={"The following jobs are still in queue:"}
         rowData={rowData}
+        repoOwner={repoOwner}
+        repoName={repoName}
       />
     );
   } else if (conclusion === GroupedJobStatus.Pending) {
@@ -436,6 +421,8 @@ function GroupTooltip({
         jobs={pendingJobs}
         message={"The following jobs are still pending:"}
         rowData={rowData}
+        repoOwner={repoOwner}
+        repoName={repoName}
       />
     );
   } else if (conclusion === GroupedJobStatus.Flaky) {
@@ -446,6 +433,8 @@ function GroupTooltip({
         jobs={failedPreviousRunJobs}
         message={"The following jobs were flaky:"}
         rowData={rowData}
+        repoOwner={repoOwner}
+        repoName={repoName}
       />
     );
   } else if (conclusion === GroupedJobStatus.AllNull) {
@@ -473,12 +462,16 @@ function ToolTip({
   message,
   jobs,
   rowData,
+  repoOwner,
+  repoName,
 }: {
   conclusion: string;
   groupName: string;
   message: string;
   jobs: JobData[];
   rowData?: RowData;
+  repoOwner?: string;
+  repoName?: string;
 }) {
   return (
     <div>
@@ -488,19 +481,30 @@ function ToolTip({
         const isAutorevert = rowData
           ? isJobAutorevertSignal(job, rowData)
           : false;
+        const isViableStrictBlocking =
+          repoOwner &&
+          repoName &&
+          isJobViableStrictBlocking(job.name, repoOwner, repoName);
         return (
-          <a
-            key={ind}
-            href={job.htmlUrl}
-            target="_blank"
-            rel="noreferrer"
-            className={
-              isAutorevert ? styles.autorevert_tooltip_anchor : undefined
-            }
-          >
-            {job.name}
-            {isAutorevert && " ⚠️ (triggered autorevert)"}
-          </a>
+          <div key={ind}>
+            <a
+              href={job.htmlUrl}
+              target="_blank"
+              rel="noreferrer"
+              className={
+                isAutorevert ? styles.autorevert_tooltip_anchor : undefined
+              }
+            >
+              {job.name}
+              {isAutorevert && " ⚠️ (triggered autorevert)"}
+            </a>
+            {isViableStrictBlocking && (
+              <span style={{ color: "orange", fontWeight: "bold" }}>
+                {" "}
+                [viable/strict blocking]
+              </span>
+            )}
+          </div>
         );
       })}
     </div>

torchci/components/job/JobConclusion.module.css

@@ -103,8 +103,9 @@
 }
 
 .viablestrict_blocking {
-  border-left: 1px solid var(--color-failure);
-  border-right: 1px solid var(--color-failure);
+  border: 2px solid var(--color-failure);
+  background-color: rgba(255, 0, 0, 0.1);
+  border-radius: 2px;
 }
 
 .autorevert_tooltip_anchor {

torchci/components/job/JobTooltip.tsx

@@ -1,3 +1,4 @@
+import { isJobViableStrictBlocking } from "lib/JobClassifierUtil";
 import { JobData } from "../../lib/types";
 import { SingleWorkflowDispatcher } from "../commit/WorkflowDispatcher";
 import LogViewer from "../common/log/LogViewer";
@@ -7,10 +8,14 @@ export default function JobTooltip({
   job,
   sha,
   isAutorevertSignal,
+  repoOwner,
+  repoName,
 }: {
   job: JobData;
   sha?: string;
   isAutorevertSignal?: boolean;
+  repoOwner?: string;
+  repoName?: string;
 }) {
   // For nonexistent jobs, just show something basic:
   if (!job.hasOwnProperty("id")) {
@@ -24,6 +29,11 @@ export default function JobTooltip({
     );
   }
 
+  const isViableStrictBlocking =
+    repoOwner &&
+    repoName &&
+    isJobViableStrictBlocking(job.name, repoOwner, repoName);
+
   return (
     <div>
       {`[${job.conclusion}] ${job.name}`}
@@ -32,6 +42,11 @@ export default function JobTooltip({
           Failure in this job has triggered autorevert.
         </div>
       )}
+      {isViableStrictBlocking && (
+        <div style={{ color: "orange", fontWeight: "bold" }}>
+          This job is viable/strict blocking.
+        </div>
+      )}
       <div>
         <em>click to pin this tooltip, double-click for job page</em>
       </div>

torchci/lib/JobClassifierUtil.ts

@@ -2,6 +2,41 @@ import { GroupedJobStatus, JobStatus } from "components/job/GroupJobConclusion";
 import { getOpenUnstableIssues } from "lib/jobUtils";
 import { IssueData, RowData } from "./types";
 
+type RepoViableStrictBlockingJobsMap = {
+  [key: string]: RegExp[];
+};
+
+// Source of truth for these jobs is in https://github.com/pytorch/pytorch/blob/main/.github/workflows/update-viablestrict.yml#L26
+export const VIABLE_STRICT_BLOCKING_JOBS: RepoViableStrictBlockingJobsMap = {
+  "pytorch/pytorch": [/pull/i, /trunk/i, /lint/i, /linux-aarch64/i],
+};
+
+export function isJobViableStrictBlocking(
+  jobName: string | undefined,
+  repoOwner: string,
+  repoName: string
+): boolean {
+  if (!jobName) {
+    return false;
+  }
+
+  // Exclude memory leak and rerun disabled tests jobs
+  if (jobName.match(/, mem_leak/) || jobName.match(/, rerun_/)) {
+    return false;
+  }
+
+  const repo = `${repoOwner}/${repoName}`;
+  const viablestrictBlockingJobsPatterns =
+    VIABLE_STRICT_BLOCKING_JOBS[repo] ?? [];
+
+  for (const regex of viablestrictBlockingJobsPatterns) {
+    if (jobName.match(regex)) {
+      return true;
+    }
+  }
+  return false;
+}
+
 const GROUP_MEMORY_LEAK_CHECK = "Memory Leak Check";
 const GROUP_RERUN_DISABLED_TESTS = "Rerun Disabled Tests";
 const GROUP_UNSTABLE = "Unstable";
@@ -355,14 +390,19 @@ export function getGroupingData(
   shaGrid: RowData[],
   jobNames: Set<string>,
   showUnstableGroup: boolean,
-  unstableIssues?: IssueData[]
+  unstableIssues?: IssueData[],
+  repoOwner?: string,
+  repoName?: string
 ) {
   // Construct Job Groupping Mapping
   const groupNameMapping = new Map<string, Array<string>>(); // group -> [job names]
 
   // Track which jobs have failures
   const jobsWithFailures = new Set<string>();
 
+  // Track which jobs are viable/strict blocking
+  const jobsViableStrictBlocking = new Set<string>();
+
   // First pass: check failures for each job across all commits
   for (const name of jobNames) {
     // Check if this job has failures in any commit
@@ -374,6 +414,15 @@ export function getGroupingData(
     if (hasFailure) {
       jobsWithFailures.add(name);
     }
+
+    // Check if this job is viable/strict blocking
+    if (
+      repoOwner &&
+      repoName &&
+      isJobViableStrictBlocking(name, repoOwner, repoName)
+    ) {
+      jobsViableStrictBlocking.add(name);
+    }
   }
 
   // Second pass: group jobs
@@ -392,11 +441,21 @@ export function getGroupingData(
     }
   }
 
+  // Calculate which groups have viable/strict blocking jobs
+  const groupsViableStrictBlocking = new Set<string>();
+  for (const [groupName, jobs] of groupNameMapping.entries()) {
+    if (jobs.some((jobName) => jobsViableStrictBlocking.has(jobName))) {
+      groupsViableStrictBlocking.add(groupName);
+    }
+  }
+
   return {
     shaGrid,
     groupNameMapping,
     jobsWithFailures,
     groupsWithFailures,
+    jobsViableStrictBlocking,
+    groupsViableStrictBlocking,
   };
 }
 

torchci/lib/useGroupingPreference.tsx

@@ -77,3 +77,15 @@ export function useHideGreenColumnsPreference(): [
   );
   return [state, setState];
 }
+
+export function useHideNonViableStrictPreference(): [
+  boolean,
+  (_hideNonViableStrictValue: boolean) => void
+] {
+  const [state, setState] = usePreference(
+    "hideNonViableStrict",
+    /*override*/ undefined,
+    /*default*/ false
+  );
+  return [state, setState];
+}