Skip to content

Commit 863dd13

Browse files
authored
Fix logic in validate aarch64 and xpu linux binaries (#6072)
1. Aarch64: Skip docker builds same as here: https://github.com/pytorch/test-infra/blob/main/.github/workflows/validate-linux-binaries.yml#L139 2. Aarch64: Fix script path 3. Aarch64: Add tests to nightly validation trigger 4. XPU: conda install path fix
1 parent 4cf1ffb commit 863dd13

File tree

3 files changed

+4
-5
lines changed

3 files changed

+4
-5
lines changed

.github/workflows/validate-aarch64-linux-binaries.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -113,6 +113,7 @@ jobs:
113113
job-name: ${{ matrix.build_name }}
114114
docker-image: ${{ matrix.container_image }}
115115
binary-matrix: ${{ toJSON(matrix) }}
116+
docker-build-dir: "skip-docker-build"
116117
no-sudo: true
117118
script: |
118119
set -ex
@@ -154,4 +155,4 @@ jobs:
154155
unset LD_LIBRARY_PATH
155156
156157
# Standard case: Validate binaries
157-
source ../../.github/scripts/validate_binaries.sh
158+
source ../../test-infra/.github/scripts/validate_binaries.sh

.github/workflows/validate-linux-binaries.yml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -155,10 +155,6 @@ jobs:
155155
156156
export USE_FORCE_REINSTALL="true"
157157
export TARGET_OS="linux"
158-
# Due to xpu doesn't use pytorch/conda-builder image, need to install conda firstly
159-
if [[ ${{ matrix.gpu_arch_type }} == 'xpu' ]]; then
160-
source /.ci/docker/common/install_conda.sh
161-
fi
162158
eval "$(conda shell.bash hook)"
163159
printf '%s\n' ${{ toJson(inputs.release-matrix) }} > release_matrix.json
164160

.github/workflows/validate-nightly-binaries.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,13 +15,15 @@ on:
1515
- .github/workflows/validate-linux-binaries.yml
1616
- .github/workflows/validate-windows-binaries.yml
1717
- .github/workflows/validate-macos-arm64-binaries.yml
18+
- .github/workflows/validate-aarch64-linux-binaries.yml
1819
- test/smoke_test/*
1920
pull_request:
2021
paths:
2122
- .github/workflows/validate-nightly-binaries.yml
2223
- .github/workflows/validate-linux-binaries.yml
2324
- .github/workflows/validate-windows-binaries.yml
2425
- .github/workflows/validate-macos-arm64-binaries.yml
26+
- .github/workflows/validate-aarch64-linux-binaries.yml
2527
- .github/scripts/validate_binaries.sh
2628
- test/smoke_test/*
2729

0 commit comments

Comments
 (0)