Skip to content

Commit 976691c

Browse files
authored
update vs2022 to fix illegal instruction. (#6968)
The old pinned version `ltsc.17.8` will cause an illegal instruction issue, we need to upgrade vs2022 to greater than `17.9.3`: pytorch/pytorch#145702 (comment) For old pinned version is for nerfstudio-project/nerfstudio#3157, and for cuda 11.8 and 12.1 builds. 1. Currently we already support cuda since 12.6. 2. `nerfstudio` fixed issue since CUDA 12.4: nerfstudio-project/nerfstudio#3157 (comment).
1 parent bc704b6 commit 976691c

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

aws/ami/windows/scripts/Installers/Install-VS.ps1

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,10 +7,10 @@ $VS_VERSION_major = [int] ${env:VS_VERSION}.split(".")[0]
77

88
$VS_DOWNLOAD_LINK = "https://aka.ms/vs/$VS_VERSION_major/release/vs_BuildTools.exe"
99

10-
# Pin to older vs_buildtools version for cuda 11.8 and 12.1 builds
11-
# see issue: https://github.com/nerfstudio-project/nerfstudio/issues/3157
10+
# Select latest LTSC version: 17.12, from https://learn.microsoft.com/en-us/visualstudio/releases/2022/release-history
11+
# The early version which fixed illegal instruction is 17.9.4, from https://github.com/pytorch/pytorch/issues/145702#issuecomment-2863244306
1212
if ( ${env:VS_YEAR} -eq "2022" ) {
13-
$VS_DOWNLOAD_LINK = "https://aka.ms/vs/17/release.ltsc.17.8/vs_buildtools.exe"
13+
$VS_DOWNLOAD_LINK = "https://aka.ms/vs/17/release.ltsc.17.12/vs_buildtools.exe"
1414
}
1515

1616
$COLLECT_DOWNLOAD_LINK = "https://aka.ms/vscollect.exe"

0 commit comments

Comments
 (0)