[ez][disablebot] Run every 6 hours instead of 3 (#6877)

As in title.  

Why: to allow flaky issues to build up more so it is more likely to
generate more aggregate issues, since right now there are a bunch but
the number doesn't hit the threshold

Also change the "was recent" calculation to be a bit more restrictive
now that the time is longer to allow for changes to propagate a bit

Testing:
Added a test and `yarn test`

Author: clee2000

.github/workflows/disable-flaky-tests.yml

@@ -2,8 +2,8 @@ name: Disable Flaky Tests
 
 on:
   schedule:
-    # At minute 39 past every 3rd hour Monday through Friday.
-    - cron: "39 */3 * * 1-5"
+    # At minute 39 past every 6th hour Monday through Friday.
+    - cron: "39 */6 * * 1-5"
   # Have the ability to trigger this job manually through the API
   workflow_dispatch:
 

torchci/pages/api/flaky-tests/disable.ts

@@ -12,7 +12,7 @@ import _ from "lodash";
 import type { NextApiRequest, NextApiResponse } from "next";
 import { Octokit } from "octokit";
 
-export const NUM_HOURS = 3;
+export const NUM_HOURS = 6;
 const PYTORCH = "pytorch";
 const THRESHOLD = 4;
 
@@ -300,7 +300,7 @@ async function handleNoLongerFlakyTests(
 function wasRecent(test: FlakyTestData) {
   if (test.eventTimes) {
     return test.eventTimes.some(
-      (value) => dayjs().diff(dayjs(value), "minutes") < NUM_HOURS * 60
+      (value) => dayjs().diff(dayjs(value), "minutes") < (NUM_HOURS - 1) * 60
     );
   }
   return true;

torchci/test/flakyBotTests/flakyBotIntegration.test.ts

@@ -83,6 +83,17 @@ describe("Disable Flaky Test Integration Tests", () => {
         handleScope(scope);
       });
 
+      test("Do not create new issue if too old", async () => {
+        const flakyTest = {
+          ...flakyTestA,
+          eventTimes: flakyTestA.eventTimes?.map((t) =>
+            dayjs().subtract(5.5, "hour").toString()
+          ),
+        };
+        // Should do nothing, so no scope
+        await disableFlakyTestBot.handleAll(octokit, [flakyTest], [], [], []);
+      });
+
       test("Comment on open issue", async () => {
         const flakyTest = { ...flakyTestA };
         const issues = [genSingleIssueFor(flakyTest, {})];