Skip to content

Commit b0c8ce4

Browse files
authored
drci: Remove OH link (#7065)
No one really attends these so let's just remove this from drci comment. Also searched the codebase for more office hours references: ``` ❯ rg office torchci ``` --------- Signed-off-by: Eli Uriegas <[email protected]>
1 parent 91e208f commit b0c8ce4

File tree

3 files changed

+1
-8
lines changed

3 files changed

+1
-8
lines changed

torchci/lib/drciUtils.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,6 @@ export const NUM_MINUTES = 30;
2626
export const REPO: string = "pytorch";
2727
export const OWNER: string = "pytorch";
2828
export const DRCI_COMMENT_START = "<!-- drci-comment-start -->\n";
29-
export const OH_URL =
30-
"https://github.com/pytorch/pytorch/wiki/Dev-Infra-Office-Hours";
3129
export const DOCS_URL = "https://docs-preview.pytorch.org";
3230
export const PYTHON_DOCS_PATH = "index.html";
3331
export const CPP_DOCS_PATH = "cppdocs/index.html";
@@ -82,7 +80,7 @@ export function formDrciHeader(
8280
### :test_tube: See artifacts and rendered test results at [hud.pytorch.org/pr/${prNum}](${HUD_URL}/pr/${prNum})
8381
* :page_facing_up: Preview [Python docs built from this PR](${DOCS_URL}/${owner}/${repo}/${prNum}/${PYTHON_DOCS_PATH})
8482
* :page_facing_up: Preview [C++ docs built from this PR](${DOCS_URL}/${owner}/${repo}/${prNum}/${CPP_DOCS_PATH})
85-
* :question: Need help or want to give feedback on the CI? Visit the [bot commands wiki](${BOT_COMMANDS_WIKI_URL}) or our [office hours](${OH_URL})
83+
* :question: Need help or want to give feedback on the CI? Visit the [bot commands wiki](${BOT_COMMANDS_WIKI_URL})
8684
8785
Note: Links to docs will display an error until the docs builds have been completed.`;
8886
}

torchci/test/drci.test.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@ import {
88
formDrciSevBody,
99
getActiveSEVs,
1010
HUD_URL,
11-
OH_URL,
1211
} from "lib/drciUtils";
1312
import * as fetchPR from "lib/fetchPR";
1413
import * as fetchRecentWorkflows from "lib/fetchRecentWorkflows";
@@ -395,7 +394,6 @@ describe("Update Dr. CI Bot Unit Tests", () => {
395394
expect(
396395
comment.includes("Need help or want to give feedback on the CI?")
397396
).toBeTruthy();
398-
expect(comment.includes(OH_URL)).toBeTruthy();
399397
expect(comment.includes(DOCS_URL)).toBeTruthy();
400398
});
401399

torchci/test/drciBot.test.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,6 @@ describe("verify-drci-functionality", () => {
7171
expect(
7272
comment.includes("Need help or want to give feedback on the CI?")
7373
).toBeTruthy();
74-
expect(comment.includes(drciUtils.OH_URL)).toBeTruthy();
7574
expect(comment.includes(drciUtils.DOCS_URL)).toBeTruthy();
7675
return true;
7776
})
@@ -119,7 +118,6 @@ describe("verify-drci-functionality", () => {
119118
expect(
120119
comment.includes("Need help or want to give feedback on the CI?")
121120
).toBeTruthy();
122-
expect(comment.includes(drciUtils.OH_URL)).toBeTruthy();
123121
expect(comment.includes(drciUtils.DOCS_URL)).toBeTruthy();
124122
return true;
125123
}
@@ -252,7 +250,6 @@ describe("verify-drci-functionality", () => {
252250
expect(
253251
comment.includes("Need help or want to give feedback on the CI?")
254252
).toBeTruthy();
255-
expect(comment.includes(drciUtils.OH_URL)).toBeTruthy();
256253
expect(comment.includes(drciUtils.DOCS_URL)).toBeTruthy();
257254
return true;
258255
}

0 commit comments

Comments
 (0)