Skip to content

Commit c9965ce

Browse files
authored
Remove rocm pre-cxx11 abi (#6103)
Forward fix for #6099 which removed pre-cxx-abi config for everything. Instead we skip generating it Rocm builds pre-cxx11 removed by: pytorch/pytorch#141423
1 parent 70d8b87 commit c9965ce

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

tools/scripts/generate_binary_build_matrix.py

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -353,10 +353,7 @@ def generate_libtorch_matrix(
353353
if os == WINDOWS:
354354
abi_versions = [RELEASE, DEBUG]
355355
elif os == LINUX:
356-
if with_rocm == ENABLE:
357-
abi_versions = [CXX11_ABI]
358-
else:
359-
abi_versions = [PRE_CXX11_ABI, CXX11_ABI]
356+
abi_versions = [PRE_CXX11_ABI, CXX11_ABI]
360357
elif os in [MACOS_ARM64]:
361358
abi_versions = [CXX11_ABI]
362359
else:
@@ -378,6 +375,10 @@ def generate_libtorch_matrix(
378375
gpu_arch_type = arch_type(arch_version)
379376
gpu_arch_version = "" if arch_version == CPU else arch_version
380377

378+
# Rocm builds where removed for pre-cxx11 abi
379+
if gpu_arch_type == "rocm" and abi_version == PRE_CXX11_ABI:
380+
continue
381+
381382
desired_cuda = translate_desired_cuda(gpu_arch_type, gpu_arch_version)
382383
devtoolset = abi_version if os != WINDOWS else ""
383384
libtorch_config = abi_version if os == WINDOWS else ""

0 commit comments

Comments
 (0)