Skip to content

Commit cc6da23

Browse files
authored
[HUD] Update some queries and regex for better viable/strict job definitions (#7093)
Similar to pytorch/pytorch#162100 Reason: rocm binary builds should not be included in viable strict upgrades and metrics that look at viable strict. Also add linux-aarch64 to some since that was missing Is this the correct way to measure trunk redness? Idk but I want it be consistent with what it says it is (considers only viable/strict blocking jobs) so we don't get confused Some have spaces after them b/c thats the easier way to guarantee that we won't accidentally include linux-binary-manywheel-rocm when we do regex for linux-binary-manywheel, and convention states that job names that include workflow is `workflow name / job name`. The places we don't need it are places that only look at workflow name and look for strict equality
1 parent ef88475 commit cc6da23

File tree

6 files changed

+35
-17
lines changed

6 files changed

+35
-17
lines changed

torchci/clickhouse_queries/master_commit_red/query.sql

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -26,10 +26,14 @@ all_runs AS (
2626
workflow_run FINAL
2727
JOIN commits commit ON workflow_run.head_commit.'id' = commit.sha
2828
WHERE
29-
(
30-
-- Limit it to workflows which block viable/strict upgrades
31-
workflow_run.name IN ('Lint', 'pull', 'trunk')
32-
OR workflow_run.name LIKE 'linux-binary%'
29+
-- Limit it to workflows which block viable/strict upgrades
30+
workflow_run.name IN (
31+
'Lint',
32+
'pull',
33+
'trunk',
34+
'linux-binary-libtorch-release',
35+
'linux-binary-manywheel',
36+
'linux-aarch64'
3337
)
3438
AND workflow_run.event != 'workflow_run' -- Filter out workflow_run-triggered jobs, which have nothing to do with the SHA
3539
AND workflow_run.id IN (

torchci/clickhouse_queries/master_commit_red_avg/query.sql

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -19,11 +19,8 @@ all_runs as (
1919
default.workflow_run as workflow_run FINAL
2020
JOIN pushes as push ON workflow_run.head_sha = push.sha
2121
WHERE
22-
(
23-
-- Limit it to workflows which block viable/strict upgrades
24-
lower(workflow_run.name) in {workflowNames:Array(String)}
25-
OR workflow_run.name like 'linux-binary%'
26-
)
22+
-- Limit it to workflows which block viable/strict upgrades
23+
lower(workflow_run.name) in {workflowNames:Array(String)}
2724
AND workflow_run.event != 'workflow_run' -- Filter out worflow_run-triggered jobs, which have nothing to do with the SHA
2825
and workflow_run.id in (
2926
select id from materialized_views.workflow_run_by_head_sha

torchci/clickhouse_queries/master_commit_red_percent/query.sql

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -32,11 +32,7 @@ all_jobs AS (
3232
WHERE head_sha in (SELECT distinct p.sha FROM pushes p)
3333
)
3434
AND j.workflow_event != 'workflow_run' -- Filter out worflow_run-triggered jobs, which have nothing to do with the SHA
35-
AND (
36-
-- Limit it to jobs which block viable/strict upgrades
37-
has({workflowNames: Array(String) }, lower(j.workflow_name))
38-
OR j.workflow_name like 'linux-binary%'
39-
)
35+
AND has({workflowNames: Array(String) }, lower(j.workflow_name))
4036
AND j.name != 'ciflow_should_run'
4137
AND j.name != 'generate-test-matrix'
4238
AND j.name NOT LIKE '%rerun_disabled_tests%'

torchci/components/job/GroupJobConclusion.tsx

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,14 @@ type RepoViableStrictBlockingJobsMap = {
4646
// TODO: Move this to a config file
4747
const VIABLE_STRICT_BLOCKING_JOBS: RepoViableStrictBlockingJobsMap = {
4848
// Source of truth for these jobs is in https://github.com/pytorch/pytorch/blob/main/.github/workflows/update-viablestrict.yml#L26
49-
"pytorch/pytorch": [/trunk/i, /pull/i, /linux-binary/i, /lint/i],
49+
"pytorch/pytorch": [
50+
/trunk/i,
51+
/pull/i,
52+
/lint/i,
53+
/linux-binary-libtorch-release /i,
54+
/linux-binary-manywheel /i,
55+
/linux-aarch64/i,
56+
],
5057
};
5158

5259
function isJobViableStrictBlocking(

torchci/pages/metrics.tsx

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -470,7 +470,14 @@ export default function Page() {
470470
JSON.stringify({
471471
...timeParams,
472472
// TODO (huydhn): Figure out a way to have default parameters for ClickHouse queries
473-
workflowNames: ["lint", "pull", "trunk"],
473+
workflowNames: [
474+
"lint",
475+
"pull",
476+
"trunk",
477+
"linux-binary-libtorch-release",
478+
"linux-binary-manywheel",
479+
"linux-aarch64",
480+
],
474481
})
475482
)}`;
476483

torchci/pages/reliability/[repoOwner]/[repoName]/[[...page]].tsx

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,14 @@ import { useCallback, useState } from "react";
2020
import useSWR from "swr";
2121
import { TimeRangePicker } from "../../../metrics";
2222

23-
const PRIMARY_WORKFLOWS = ["lint", "pull", "trunk"];
23+
const PRIMARY_WORKFLOWS = [
24+
"lint",
25+
"pull",
26+
"trunk",
27+
"linux-binary-libtorch-release",
28+
"linux-binary-manywheel",
29+
"linux-aarch64",
30+
];
2431
const SECONDARY_WORKFLOWS = ["periodic", "inductor"];
2532
const UNSTABLE_WORKFLOWS = ["unstable"];
2633
const LAST_WEEK = 7;

0 commit comments

Comments
 (0)