Skip to content

Commit cfc5f99

Browse files
authored
[Nova] Escape forward slashes in ref name (#6281)
As reported by @drisspg where his build fails because the ref includes some forward slashes https://github.com/pytorch/ao/actions/runs/13275832470/job/37065164277 @drisspg I add your ref as a test case, so please keep it around instead of deleting it. I wonder if this is a smart thing to include. ### Testing https://github.com/pytorch/test-infra/actions/runs/13281773348/job/37081535345?pr=6281
1 parent 3e660b3 commit cfc5f99

File tree

4 files changed

+10
-11
lines changed

4 files changed

+10
-11
lines changed

.github/actions/setup-binary-builds/action.yml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -95,8 +95,9 @@ runs:
9595
run: |
9696
set -euxo pipefail
9797
# Set artifact name here since github actions doesn't have string manipulation tools
98-
# and "/" is not allowed in artifact names
99-
echo "ARTIFACT_NAME=${REPOSITORY/\//_}_${REF}_${PYTHON_VERSION}_${CU_VERSION}_${ARCH}" >> "${GITHUB_ENV}"
98+
# and "/" is not allowed in artifact names. //\//_ is to replace all forward slashes,
99+
# not just the first one
100+
echo "ARTIFACT_NAME=${REPOSITORY//\//_}_${REF//\//_}_${PYTHON_VERSION}_${CU_VERSION}_${ARCH}" >> "${GITHUB_ENV}"
100101
- name: Setup miniconda (for pytorch_pkg_helpers)
101102
if: ${{ inputs.setup-miniconda == 'true' }}
102103
uses: conda-incubator/[email protected]

.github/actions/setup-binary-upload/action.yml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,8 +50,9 @@ runs:
5050
set -ex
5151
5252
# Set artifact name here since github actions doesn't have string manipulation tools
53-
# and "/" is not allowed in artifact names
54-
echo "ARTIFACT_NAME=${REPOSITORY/\//_}_${REF}_${PYTHON_VERSION}_${CU_VERSION}_${ARCH}" >> "${GITHUB_ENV}"
53+
# and "/" is not allowed in artifact names. //\//_ is to replace all forward slashes,
54+
# not just the first one
55+
echo "ARTIFACT_NAME=${REPOSITORY//\//_}_${REF//\//_}_${PYTHON_VERSION}_${CU_VERSION}_${ARCH}" >> "${GITHUB_ENV}"
5556
5657
# Need to checkout the target repository to run pkg-helpers
5758
- uses: actions/checkout@v4

.github/workflows/test_build_wheels_linux_without_cuda.yml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,4 +44,7 @@ jobs:
4444
build-matrix: ${{ needs.generate-matrix.outputs.matrix }}
4545
package-name: ${{ matrix.package-name }}
4646
trigger-event: "${{ github.event_name }}"
47-
build-platform: 'python-build-package'
47+
build-platform: python-build-package
48+
pip-install-torch-extra-args:
49+
torchvision
50+
torchao

.github/workflows/test_build_wheels_windows_with_cuda.yml

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -28,11 +28,6 @@ jobs:
2828
fail-fast: false
2929
matrix:
3030
include:
31-
- repository: pytorch/audio
32-
env-script: packaging/vc_env_helper.bat
33-
wheel-build-params: "--plat-name win_amd64"
34-
smoke-test-script: test/smoke_test/smoke_test.py
35-
package-name: torchaudio
3631
- repository: pytorch/vision
3732
pre-script: packaging/pre_build_script.sh
3833
env-script: packaging/windows/internal/vc_env_helper.bat
@@ -51,7 +46,6 @@ jobs:
5146
build-matrix: ${{ needs.generate-matrix.outputs.matrix }}
5247
pre-script: ${{ matrix.pre-script }}
5348
env-script: ${{ matrix.env-script }}
54-
wheel-build-params: ${{ matrix.wheel-build-params }}
5549
post-script: ${{ matrix.post-script }}
5650
smoke-test-script: ${{ matrix.smoke-test-script }}
5751
package-name: ${{ matrix.package-name }}

0 commit comments

Comments
 (0)