Skip to content

Commit f6c5d6d

Browse files
authored
Use rocm images for rocm validations and set devtoolset correctly similar to xpu (#6080)
1 parent baa135f commit f6c5d6d

File tree

2 files changed

+7
-2
lines changed

2 files changed

+7
-2
lines changed

.github/scripts/validate_binaries.sh

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,8 +78,13 @@ else
7878

7979
pushd ${PWD}/.ci/pytorch/
8080

81-
if [[ ${MATRIX_GPU_ARCH_VERSION} == "12.6" || ${MATRIX_GPU_ARCH_TYPE} == "xpu" ]]; then
81+
if [[ ${MATRIX_GPU_ARCH_VERSION} == "12.6" || ${MATRIX_GPU_ARCH_TYPE} == "xpu" || ${MATRIX_GPU_ARCH_TYPE} == "rocm" ]]; then
8282
export DESIRED_DEVTOOLSET="cxx11-abi"
83+
84+
# TODO: enable torch-compile on ROCM
85+
if [[ ${MATRIX_GPU_ARCH_TYPE} == "rocm" ]]; then
86+
TEST_SUFFIX=${TEST_SUFFIX}" --torch-compile-check disabled"
87+
fi
8388
fi
8489

8590
if [[ ${TARGET_OS} == 'linux' ]]; then

.github/workflows/validate-linux-binaries.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -134,7 +134,7 @@ jobs:
134134
repository: "pytorch/pytorch"
135135
ref: main
136136
job-name: ${{ matrix.build_name }}
137-
docker-image: ${{ (matrix.gpu_arch_type == 'xpu' && matrix.container_image) || (matrix.gpu_arch_version == '12.6' && 'pytorch/almalinux-builder:cpu-main') || 'pytorch/conda-builder' }}
137+
docker-image: ${{ ((matrix.gpu_arch_type == 'xpu' || matrix.gpu_arch_type == 'rocm') && matrix.container_image) || (matrix.gpu_arch_version == '12.6' && 'pytorch/almalinux-builder:cpu-main') || 'pytorch/conda-builder' }}
138138
binary-matrix: ${{ toJSON(matrix) }}
139139
docker-build-dir: "skip-docker-build"
140140
timeout: 180

0 commit comments

Comments
 (0)