Return the list of artifacts from mobile job #5727
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
facebook-github-bot
added
the
CLA Signed
huydhn
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
clee2000
approved these changes
Oct 1, 2024
huydhn
added a commit
to pytorch/executorch
that referenced
this pull request
Oct 2, 2024
guangy10
approved these changes
Oct 2, 2024
kirklandsign
approved these changes
Oct 2, 2024
4 tasks
huydhn
added a commit
that referenced
this pull request
Oct 5, 2024
This adds a GHA to upload benchmark results. I'm using the existing `torchci-oss-ci-benchmark` database for now until the new generic database from https://fburl.com/gdoc/ossgtvte is ready. So, it's backed by dynamoDB instead of S3 for now. I also include a quick test with some dummy Android benchmark records. * [x] Get the list of artifacts #5727 * [x] On ExecuTorch side, extract the benchmark JSON from the artifacts pytorch/executorch#5808 * [x] Create a new GitHub action on test-infra to upload the JSON #5742 * [x] Create a new GHA role to upload the results meta-pytorch/pytorch-gha-infra#483
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the mobile job to return the list of artifacts from AWS to the caller to use as they see fit. One of the use case is for ExecuTorch to extract the benchmark results JSON from
CUSTOMER_ARTIFACTandTESTSPEC_OUTPUT(2 types of artifacts from AWS).My plan here is to:
Minor fixes:
TESTSPEC_OUTPUT, which is basically the main output from the device.