Add a GHA to upload benchmark results #5742
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
facebook-github-bot
added
the
CLA Signed
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
clee2000
approved these changes
Oct 3, 2024
Contributor
|
What tables do our runners have access to? It seems a bit weird that they can upload to dynamodb |
Contributor
Author
Oh, the test job is in dry-run mode, it doesn't insert anything. I'm creating a GHA role atm for this |
Contributor
Author
|
@clee2000 Here is the role https://github.com/pytorch-labs/pytorch-gha-infra/pull/483, plz help do a quick review there |
huydhn
added a commit
to pytorch/executorch
that referenced
this pull request
Oct 5, 2024
Summary: This PR adds a job to upload Android benchmark results to the benchmark database. It transforms the `benchmark_results.json` file slightly to fit into the current schema. We are going to have a better schema soon https://fburl.com/gdoc/ossgtvte, but landing this first would unblock the work on building the dashboard before the launch. Updating the schema can be done later. * The job processes what it finds, so if one model fails, the rest will still be uploaded. * I will follow up with another PR for iOS later. No need to wait for the TPS metric there, we'll upload what available first. There are still some TODO pending: * pytorch/test-infra#5742 * meta-pytorch/pytorch-gha-infra#483 But the structure of the CI job is ready to review. Pull Request resolved: #5808 Reviewed By: guangy10, kirklandsign Differential Revision: D63869876 Pulled By: huydhn
facebook-github-bot
pushed a commit
to pytorch/executorch
that referenced
this pull request
Oct 5, 2024
Summary: This PR adds a job to upload Android benchmark results to the benchmark database. It transforms the `benchmark_results.json` file slightly to fit into the current schema. We are going to have a better schema soon https://fburl.com/gdoc/ossgtvte, but landing this first would unblock the work on building the dashboard before the launch. Updating the schema can be done later. * The job processes what it finds, so if one model fails, the rest will still be uploaded. * I will follow up with another PR for iOS later. No need to wait for the TPS metric there, we'll upload what available first. There are still some TODO pending: * pytorch/test-infra#5742 * meta-pytorch/pytorch-gha-infra#483 But the structure of the CI job is ready to review. Pull Request resolved: #5808 Reviewed By: guangy10, kirklandsign Differential Revision: D63869876 Pulled By: huydhn fbshipit-source-id: f9bf85c9599fafbfcc300d47e4307230c46b16db
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a GHA to upload benchmark results. I'm using the existing
torchci-oss-ci-benchmarkdatabase for now until the new generic database from https://fburl.com/gdoc/ossgtvte is ready. So, it's backed by dynamoDB instead of S3 for now.I also include a quick test with some dummy Android benchmark records.